Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(659)

Unified Diff: third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotView.js

Issue 2626173002: DevTools: Extract HeapSnapshotCommon.js into HeapSnapshotModel module (Closed)
Patch Set: add module.json for modules Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotView.js b/third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotView.js
index 5566e2131783823f970c91fc237d52e363a4b7da..6d71c631d571e4d3ab23565723eeba05d985d660 100644
--- a/third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotView.js
+++ b/third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotView.js
@@ -212,7 +212,7 @@ Profiler.HeapSnapshotView = class extends UI.SimpleView {
}
/**
- * @param {!Profiler.HeapSnapshotCommon.Statistics} statistics
+ * @param {!HeapSnapshotModel.Statistics} statistics
*/
_gotStatistics(statistics) {
this._statisticsView.setTotal(statistics.total);
@@ -303,7 +303,7 @@ Profiler.HeapSnapshotView = class extends UI.SimpleView {
* @param {boolean=} jumpBackwards
*/
performSearch(searchConfig, shouldJump, jumpBackwards) {
- var nextQuery = new Profiler.HeapSnapshotCommon.SearchConfig(
+ var nextQuery = new HeapSnapshotModel.SearchConfig(
searchConfig.query.trim(), searchConfig.caseSensitive, searchConfig.isRegex, shouldJump,
jumpBackwards || false);
@@ -311,7 +311,7 @@ Profiler.HeapSnapshotView = class extends UI.SimpleView {
}
/**
- * @param {!Profiler.HeapSnapshotCommon.SearchConfig} nextQuery
+ * @param {!HeapSnapshotModel.SearchConfig} nextQuery
* @return {!Promise<?>}
*/
_performSearch(nextQuery) {
@@ -1416,13 +1416,13 @@ Profiler.HeapProfileHeader = class extends Profiler.ProfileHeader {
* @param {*} data
*/
_handleWorkerEvent(eventName, data) {
- if (Profiler.HeapSnapshotProgressEvent.BrokenSnapshot === eventName) {
+ if (HeapSnapshotModel.HeapSnapshotProgressEvent.BrokenSnapshot === eventName) {
var error = /** @type {string} */ (data);
Common.console.error(error);
return;
}
- if (Profiler.HeapSnapshotProgressEvent.Update !== eventName)
+ if (HeapSnapshotModel.HeapSnapshotProgressEvent.Update !== eventName)
return;
var subtitle = /** @type {string} */ (data);
this.updateStatus(subtitle);
@@ -1686,7 +1686,7 @@ Profiler.HeapTrackingOverviewGrid = class extends UI.VBox {
}
/**
- * @param {?Profiler.HeapSnapshotCommon.Samples} samples
+ * @param {?HeapSnapshotModel.Samples} samples
*/
_setSamples(samples) {
if (!samples)
@@ -2081,7 +2081,7 @@ Profiler.HeapAllocationStackView = class extends UI.Widget {
}
/**
- * @param {?Array.<!Profiler.HeapSnapshotCommon.AllocationStackFrame>} frames
+ * @param {?Array.<!HeapSnapshotModel.AllocationStackFrame>} frames
*/
_didReceiveAllocationStack(frames) {
if (!frames) {

Powered by Google App Engine
This is Rietveld 408576698