Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Unified Diff: third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotProxy.js

Issue 2626173002: DevTools: Extract HeapSnapshotCommon.js into HeapSnapshotModel module (Closed)
Patch Set: add module.json for modules Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotProxy.js
diff --git a/third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotProxy.js b/third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotProxy.js
index 0005305848d3852df5bdc4b39bf68d5e87c084af..7020403e6daaa155480f3ae018f6aed9de53cc0f 100644
--- a/third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotProxy.js
+++ b/third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotProxy.js
@@ -334,13 +334,13 @@ Profiler.HeapSnapshotProxy = class extends Profiler.HeapSnapshotProxyObject {
*/
constructor(worker, objectId) {
super(worker, objectId);
- /** @type {?Profiler.HeapSnapshotCommon.StaticData} */
+ /** @type {?HeapSnapshotModel.StaticData} */
this._staticData = null;
}
/**
- * @param {!Profiler.HeapSnapshotCommon.SearchConfig} searchConfig
- * @param {!Profiler.HeapSnapshotCommon.NodeFilter} filter
+ * @param {!HeapSnapshotModel.SearchConfig} searchConfig
+ * @param {!HeapSnapshotModel.NodeFilter} filter
* @return {!Promise<!Array<number>>}
*/
search(searchConfig, filter) {
@@ -348,8 +348,8 @@ Profiler.HeapSnapshotProxy = class extends Profiler.HeapSnapshotProxyObject {
}
/**
- * @param {!Profiler.HeapSnapshotCommon.NodeFilter} filter
- * @param {function(!Object.<string, !Profiler.HeapSnapshotCommon.Aggregate>)} callback
+ * @param {!HeapSnapshotModel.NodeFilter} filter
+ * @param {function(!Object.<string, !HeapSnapshotModel.Aggregate>)} callback
*/
aggregatesWithFilter(filter, callback) {
this.callMethod(callback, 'aggregatesWithFilter', filter);
@@ -415,7 +415,7 @@ Profiler.HeapSnapshotProxy = class extends Profiler.HeapSnapshotProxyObject {
/**
* @param {string} className
- * @param {!Profiler.HeapSnapshotCommon.NodeFilter} nodeFilter
+ * @param {!HeapSnapshotModel.NodeFilter} nodeFilter
* @return {?Profiler.HeapSnapshotProviderProxy}
*/
createNodesProviderForClass(className, nodeFilter) {
@@ -429,7 +429,7 @@ Profiler.HeapSnapshotProxy = class extends Profiler.HeapSnapshotProxyObject {
/**
* @param {number} nodeId
- * @param {function(!Profiler.HeapSnapshotCommon.AllocationNodeCallers)} callback
+ * @param {function(!HeapSnapshotModel.AllocationNodeCallers)} callback
*/
allocationNodeCallers(nodeId, callback) {
this.callMethod(callback, 'allocationNodeCallers', nodeId);
@@ -437,7 +437,7 @@ Profiler.HeapSnapshotProxy = class extends Profiler.HeapSnapshotProxyObject {
/**
* @param {number} nodeIndex
- * @param {function(?Array.<!Profiler.HeapSnapshotCommon.AllocationStackFrame>)} callback
+ * @param {function(?Array.<!HeapSnapshotModel.AllocationStackFrame>)} callback
*/
allocationStack(nodeIndex, callback) {
this.callMethod(callback, 'allocationStack', nodeIndex);
@@ -460,7 +460,7 @@ Profiler.HeapSnapshotProxy = class extends Profiler.HeapSnapshotProxyObject {
updateStaticData(callback) {
/**
- * @param {!Profiler.HeapSnapshotCommon.StaticData} staticData
+ * @param {!HeapSnapshotModel.StaticData} staticData
* @this {Profiler.HeapSnapshotProxy}
*/
function dataReceived(staticData) {
@@ -471,14 +471,14 @@ Profiler.HeapSnapshotProxy = class extends Profiler.HeapSnapshotProxyObject {
}
/**
- * @return {!Promise.<!Profiler.HeapSnapshotCommon.Statistics>}
+ * @return {!Promise.<!HeapSnapshotModel.Statistics>}
*/
getStatistics() {
return this._callMethodPromise('getStatistics');
}
/**
- * @return {!Promise.<?Profiler.HeapSnapshotCommon.Samples>}
+ * @return {!Promise.<?HeapSnapshotModel.Samples>}
*/
getSamples() {
return this._callMethodPromise('getSamples');
@@ -538,7 +538,7 @@ Profiler.HeapSnapshotProviderProxy = class extends Profiler.HeapSnapshotProxyObj
* @override
* @param {number} startPosition
* @param {number} endPosition
- * @param {function(!Profiler.HeapSnapshotCommon.ItemsRange)} callback
+ * @param {function(!HeapSnapshotModel.ItemsRange)} callback
*/
serializeItemsRange(startPosition, endPosition, callback) {
this.callMethod(callback, 'serializeItemsRange', startPosition, endPosition);
@@ -546,7 +546,7 @@ Profiler.HeapSnapshotProviderProxy = class extends Profiler.HeapSnapshotProxyObj
/**
* @override
- * @param {!Profiler.HeapSnapshotCommon.ComparatorConfig} comparator
+ * @param {!HeapSnapshotModel.ComparatorConfig} comparator
* @return {!Promise<?>}
*/
sortAndRewind(comparator) {

Powered by Google App Engine
This is Rietveld 408576698