DevTools: Extract HeapSnapshotCommon.js into HeapSnapshotModel module

third_party/WebKit/Source/devtools/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/features.gni")
 import("//third_party/WebKit/public/public_features.gni")
 import("//third_party/WebKit/Source/core/core.gni")
 
 all_devtools_files = [
   "front_end/accessibility/AccessibilityModel.js",
@@ skipping 217 matching lines @@
   "front_end/formatter_worker/FormatterWorker.js",
   "front_end/formatter_worker/HTMLFormatter.js",
   "front_end/formatter_worker/IdentityFormatter.js",
   "front_end/formatter_worker/JavaScriptFormatter.js",
   "front_end/formatter_worker/JavaScriptOutline.js",
   "front_end/formatter_worker/module.json",
   "front_end/formatter_worker/RelaxedJSONParser.js",
   "front_end/gonzales/gonzales-scss.js",
   "front_end/gonzales/module.json",
   "front_end/gonzales/SCSSParser.js",
+  "front_end/heap_snapshot_model/HeapSnapshotModel.js",

[pfeldman, 2017/01/11 23:01:42]

it needs to have a module.json

[chenwilliam, 2017/01/11 23:41:59]

done. I added it for all the new modules I made recently (and updated the
extract_module script).

   "front_end/heap_snapshot_worker.js",
   "front_end/heap_snapshot_worker.json",
   "front_end/heap_snapshot_worker/AllocationProfile.js",
   "front_end/heap_snapshot_worker/HeapSnapshot.js",
   "front_end/heap_snapshot_worker/HeapSnapshotLoader.js",
   "front_end/heap_snapshot_worker/HeapSnapshotWorker.js",
   "front_end/heap_snapshot_worker/HeapSnapshotWorkerDispatcher.js",
   "front_end/heap_snapshot_worker/module.json",
   "front_end/host/InspectorFrontendHost.js",
   "front_end/host/InspectorFrontendHostAPI.js",
@@ skipping 95 matching lines @@
   "front_end/persistence/FileSystemWorkspaceBinding.js",
   "front_end/persistence/Persistence.js",
   "front_end/persistence/PersistenceUtils.js",
   "front_end/platform/module.json",
   "front_end/platform/utilities.js",
   "front_end/profiler/BottomUpProfileDataGrid.js",
   "front_end/profiler/CPUProfileFlameChart.js",
   "front_end/profiler/CPUProfileView.js",
   "front_end/profiler/heapProfiler.css",
   "front_end/profiler/HeapProfileView.js",
-  "front_end/profiler/HeapSnapshotCommon.js",
   "front_end/profiler/HeapSnapshotDataGrids.js",
   "front_end/profiler/HeapSnapshotGridNodes.js",
   "front_end/profiler/HeapSnapshotProxy.js",
   "front_end/profiler/HeapSnapshotView.js",
   "front_end/profiler/module.json",
   "front_end/profiler/ProfileDataGrid.js",
   "front_end/profiler/ProfileLauncherView.js",
   "front_end/profiler/profilesPanel.css",
   "front_end/profiler/ProfilesPanel.js",
   "front_end/profiler/profilesSidebarTree.css",
@@ skipping 430 matching lines @@
   "$resources_out_dir/audits2/audits2_module.js",
   "$resources_out_dir/cm/cm_module.js",
   "$resources_out_dir/color_picker/color_picker_module.js",
   "$resources_out_dir/console/console_module.js",
   "$resources_out_dir/cookie_table/cookie_table_module.js",
   "$resources_out_dir/css_tracker/css_tracker_module.js",
   "$resources_out_dir/data_grid/data_grid_module.js",
   "$resources_out_dir/devices/devices_module.js",
   "$resources_out_dir/diff/diff_module.js",
   "$resources_out_dir/elements/elements_module.js",
+  "$resources_out_dir/heap_snapshot_model/heap_snapshot_model_module.js",
   "$resources_out_dir/inline_editor/inline_editor_module.js",
   "$resources_out_dir/layer_viewer/layer_viewer_module.js",
   "$resources_out_dir/layers/layers_module.js",
   "$resources_out_dir/network/network_module.js",
   "$resources_out_dir/perf_ui/perf_ui_module.js",
   "$resources_out_dir/profiler/profiler_module.js",
   "$resources_out_dir/quick_open/quick_open_module.js",
   "$resources_out_dir/resources/resources_module.js",
   "$resources_out_dir/sass/sass_module.js",
   "$resources_out_dir/security/security_module.js",
@@ skipping 246 matching lines @@
     ".eslintrc.js",
     "devtools-node-modules/",
     "front_end/",
     "scripts/buildbot/run_eslint.py",
     "scripts/local_node/",
     "//testing/scripts/common.py",
     "//testing/scripts/run_devtools_check.py",
     "//testing/xvfb.py",
   ]
 }