Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1264)

Issue 2626043007: Clean up chrome://version page. (Closed)

Created:
3 years, 11 months ago by michaelpg
Modified:
3 years, 10 months ago
CC:
chromium-reviews, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up chrome://version page. The version UI has a bunch of unused stuff and a bunch of per-platform strings that are included on all platforms. Make it a little better. BUG=681133 R=xiyuan@chromium.org,michaeldo@chromium.org,eugenebut@chromium.org Review-Url: https://codereview.chromium.org/2626043007 Cr-Commit-Position: refs/heads/master@{#446905} Committed: https://chromium.googlesource.com/chromium/src/+/dcf341fef4994468f4ec8e384a8dcdc7ece9d3ff

Patch Set 1 #

Patch Set 2 : fix compile #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Patch Set 5 : fix rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -68 lines) Patch
M chrome/app/generated_resources.grd View 1 2 3 4 1 chunk +6 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/version_ui.cc View 1 2 3 4 5 chunks +37 lines, -42 lines 0 comments Download
M components/version_ui/resources/about_version.html View 4 chunks +5 lines, -9 lines 0 comments Download
M components/version_ui/resources/about_version.js View 1 chunk +3 lines, -2 lines 0 comments Download
M components/version_ui/version_ui_constants.h View 1 2 chunks +21 lines, -1 line 0 comments Download
M components/version_ui/version_ui_constants.cc View 1 chunk +19 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/ios_strings.grd View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/webui/version_ui.mm View 1 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 30 (18 generated)
michaelpg
thoughts?
3 years, 11 months ago (2017-01-13 22:37:20 UTC) #7
Dan Beam
i probably wont have time to look at this until next week :(
3 years, 11 months ago (2017-01-18 02:22:35 UTC) #10
michaelpg
On 2017/01/18 02:22:35, Dan Beam (slow - converging) wrote: > i probably wont have time ...
3 years, 11 months ago (2017-01-18 02:25:57 UTC) #11
Dan Beam
On 2017/01/18 02:25:57, michaelpg wrote: > On 2017/01/18 02:22:35, Dan Beam (slow - converging) wrote: ...
3 years, 11 months ago (2017-01-24 05:31:18 UTC) #12
michaelpg
xiyuan, could you take a look for components/version_ui? +Mike for ios.
3 years, 11 months ago (2017-01-24 06:16:11 UTC) #14
xiyuan
lgtm
3 years, 11 months ago (2017-01-24 18:24:02 UTC) #15
michaeldo
lgtm +eugenebut for commiter approval
3 years, 11 months ago (2017-01-24 18:58:06 UTC) #17
Eugene But (OOO till 7-30)
lgtm
3 years, 11 months ago (2017-01-24 21:52:33 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2626043007/60001
3 years, 10 months ago (2017-01-27 23:48:00 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: android_cronet on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_cronet/builds/73484)
3 years, 10 months ago (2017-01-28 00:05:08 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2626043007/80001
3 years, 10 months ago (2017-01-28 03:15:42 UTC) #27
commit-bot: I haz the power
3 years, 10 months ago (2017-01-28 04:12:02 UTC) #30
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/dcf341fef4994468f4ec8e384a8d...

Powered by Google App Engine
This is Rietveld 408576698