Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1434)

Unified Diff: components/version_ui/version_ui_constants.h

Issue 2626043007: Clean up chrome://version page. (Closed)
Patch Set: fix rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/version_ui/resources/about_version.js ('k') | components/version_ui/version_ui_constants.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/version_ui/version_ui_constants.h
diff --git a/components/version_ui/version_ui_constants.h b/components/version_ui/version_ui_constants.h
index 7f0d3e85b11cbfd1a50e97270023a100729dc6c3..88a89288a8011eacf40bdb58cfdc0a22e9d98d58 100644
--- a/components/version_ui/version_ui_constants.h
+++ b/components/version_ui/version_ui_constants.h
@@ -5,6 +5,8 @@
#ifndef COMPONENTS_VERSION_UI_VERSION_UI_CONSTANTS_H_
#define COMPONENTS_VERSION_UI_VERSION_UI_CONSTANTS_H_
+#include "build/build_config.h"
+
namespace version_ui {
// Resource paths.
@@ -22,29 +24,47 @@ extern const char kReturnVariationInfo[];
// Strings.
// Must match the constants used in the resource files.
extern const char kApplicationLabel[];
+#if defined(OS_CHROMEOS)
extern const char kARC[];
-extern const char kBlinkVersion[];
+#endif
extern const char kCL[];
extern const char kCommandLine[];
extern const char kCommandLineName[];
extern const char kCompany[];
+#if defined(OS_WIN)
+extern const char kCompiler[];
+#endif
extern const char kCopyright[];
#if defined(OS_CHROMEOS)
extern const char kCustomizationId[];
#endif
+#if !defined(OS_IOS)
extern const char kExecutablePath[];
extern const char kExecutablePathName[];
+#endif
+#if !defined(OS_ANDROID) && !defined(OS_IOS)
extern const char kFlashPlugin[];
extern const char kFlashVersion[];
+#endif
+#if !defined(OS_IOS)
extern const char kJSEngine[];
extern const char kJSVersion[];
+#endif
extern const char kOfficial[];
+#if !defined(OS_CHROMEOS)
extern const char kOSName[];
extern const char kOSType[];
+#endif
+#if defined(OS_ANDROID)
extern const char kOSVersion[];
+#endif
+#if defined(OS_CHROMEOS)
extern const char kPlatform[];
+#endif
+#if !defined(OS_IOS)
extern const char kProfilePath[];
extern const char kProfilePathName[];
+#endif
extern const char kRevision[];
extern const char kTitle[];
extern const char kUserAgent[];
« no previous file with comments | « components/version_ui/resources/about_version.js ('k') | components/version_ui/version_ui_constants.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698