Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Unified Diff: ios/chrome/browser/ui/webui/version_ui.mm

Issue 2626043007: Clean up chrome://version page. (Closed)
Patch Set: fix rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/app/strings/ios_strings.grd ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ui/webui/version_ui.mm
diff --git a/ios/chrome/browser/ui/webui/version_ui.mm b/ios/chrome/browser/ui/webui/version_ui.mm
index 76a51fd2a04fd33f76a0177c5e88dc73c51a0ceb..26aa367f5abf6d01caefa0376ed11e92c27e10f3 100644
--- a/ios/chrome/browser/ui/webui/version_ui.mm
+++ b/ios/chrome/browser/ui/webui/version_ui.mm
@@ -21,7 +21,6 @@
#include "ios/chrome/browser/ui/webui/version_handler.h"
#include "ios/chrome/common/channel_info.h"
#include "ios/chrome/grit/ios_chromium_strings.h"
-#include "ios/chrome/grit/ios_strings.h"
#include "ios/web/public/web_client.h"
#include "ios/web/public/web_ui_ios_data_source.h"
#include "ios/web/public/webui/web_ui_ios.h"
@@ -46,10 +45,7 @@ web::WebUIIOSDataSource* CreateVersionUIDataSource() {
html_source->AddString(version_ui::kVersionModifier,
GetChannelString(GetChannel()));
html_source->AddLocalizedString(version_ui::kOSName, IDS_VERSION_UI_OS);
- html_source->AddLocalizedString(version_ui::kPlatform,
- IDS_IOS_PLATFORM_LABEL);
html_source->AddString(version_ui::kOSType, version_info::GetOSType());
- html_source->AddString(version_ui::kOSVersion, std::string());
html_source->AddLocalizedString(version_ui::kCompany,
IDS_IOS_ABOUT_VERSION_COMPANY_NAME);
« no previous file with comments | « ios/chrome/app/strings/ios_strings.grd ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698