Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Unified Diff: components/version_ui/version_ui_constants.cc

Issue 2626043007: Clean up chrome://version page. (Closed)
Patch Set: fix rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/version_ui/version_ui_constants.h ('k') | ios/chrome/app/strings/ios_strings.grd » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/version_ui/version_ui_constants.cc
diff --git a/components/version_ui/version_ui_constants.cc b/components/version_ui/version_ui_constants.cc
index 5c4e824fc62f9b1966c9d5856bd4ec4b9015597a..d16045deee4c38f83026d4bddf452079723d6e22 100644
--- a/components/version_ui/version_ui_constants.cc
+++ b/components/version_ui/version_ui_constants.cc
@@ -18,28 +18,47 @@ const char kReturnVariationInfo[] = "returnVariationInfo";
// Strings.
const char kApplicationLabel[] = "application_label";
+#if defined(OS_CHROMEOS)
const char kARC[] = "arc_label";
+#endif
const char kCL[] = "cl";
const char kCommandLine[] = "command_line";
const char kCommandLineName[] = "command_line_name";
const char kCompany[] = "company";
+#if defined(OS_WIN)
+const char kCompiler[] = "compiler";
+#endif
const char kCopyright[] = "copyright";
#if defined(OS_CHROMEOS)
const char kCustomizationId[] = "customization_id";
#endif
+#if !defined(OS_IOS)
const char kExecutablePath[] = "executable_path";
const char kExecutablePathName[] = "executable_path_name";
+#endif
+#if !defined(OS_ANDROID) && !defined(OS_IOS)
const char kFlashPlugin[] = "flash_plugin";
const char kFlashVersion[] = "flash_version";
+#endif
+#if !defined(OS_IOS)
const char kJSEngine[] = "js_engine";
const char kJSVersion[] = "js_version";
+#endif
const char kOfficial[] = "official";
+#if !defined(OS_CHROMEOS)
const char kOSName[] = "os_name";
const char kOSType[] = "os_type";
+#endif
+#if defined(OS_ANDROID)
const char kOSVersion[] = "os_version";
+#endif
+#if defined(OS_CHROMEOS)
const char kPlatform[] = "platform";
+#endif
+#if !defined(OS_IOS)
const char kProfilePath[] = "profile_path";
const char kProfilePathName[] = "profile_path_name";
+#endif
const char kRevision[] = "revision";
const char kTitle[] = "title";
const char kUserAgent[] = "useragent";
« no previous file with comments | « components/version_ui/version_ui_constants.h ('k') | ios/chrome/app/strings/ios_strings.grd » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698