Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 2625423002: Rename "icon" to "primary icon" in InstallableManager (Closed)

Created:
3 years, 11 months ago by F
Modified:
3 years, 11 months ago
Reviewers:
dominickn, pkotwicz
CC:
chromium-reviews, zpeng+watch_chromium.org, pkotwicz+watch_chromium.org, dominickn+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename "icon" to "primary icon" in InstallableManager. This CL renames "icon" to "primary icon" in InstallableParams & InstallableData in InstallableManager to differentiate icons with purpose "any" from icons with purpose "badge". Followup CLs will update InstallableManager to download icons with purpose "badge" if "badge" icons are requested. BUG=649771 Review-Url: https://codereview.chromium.org/2625423002 Cr-Commit-Position: refs/heads/master@{#443896} Committed: https://chromium.googlesource.com/chromium/src/+/919511bd14650ee9b2dde04116861f5c52db30c5

Patch Set 1 #

Patch Set 2 : Rename "default" to "primary" #

Patch Set 3 : Rename "icon" to "priamry icon" in InstallableData #

Total comments: 2

Patch Set 4 : Addressing comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -66 lines) Patch
M chrome/browser/android/webapk/webapk_update_data_fetcher.cc View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/banners/app_banner_manager.cc View 1 2 2 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/installable/installable_manager.h View 1 2 3 2 chunks +17 lines, -14 lines 0 comments Download
M chrome/browser/installable/installable_manager.cc View 1 6 chunks +13 lines, -12 lines 0 comments Download
M chrome/browser/installable/installable_manager_browsertest.cc View 1 2 7 chunks +21 lines, -21 lines 0 comments Download

Messages

Total messages: 27 (20 generated)
F
Hi Dominick & Peter, PTAL. Thanks!
3 years, 11 months ago (2017-01-12 23:07:32 UTC) #10
dominickn
Hi Felix, I'm not sure "default" is the best name here. Perhaps "primary" is a ...
3 years, 11 months ago (2017-01-12 23:22:14 UTC) #11
F
On 2017/01/12 23:22:14, dominickn wrote: > Hi Felix, > > I'm not sure "default" is ...
3 years, 11 months ago (2017-01-13 15:46:57 UTC) #13
dominickn
lgtm % nit https://codereview.chromium.org/2625423002/diff/40001/chrome/browser/installable/installable_manager.h File chrome/browser/installable/installable_manager.h (right): https://codereview.chromium.org/2625423002/diff/40001/chrome/browser/installable/installable_manager.h#newcode41 chrome/browser/installable/installable_manager.h:41: // Check whether there is a ...
3 years, 11 months ago (2017-01-16 02:10:06 UTC) #20
F
Thanks Dominick! I'm going to submit it soon https://codereview.chromium.org/2625423002/diff/40001/chrome/browser/installable/installable_manager.h File chrome/browser/installable/installable_manager.h (right): https://codereview.chromium.org/2625423002/diff/40001/chrome/browser/installable/installable_manager.h#newcode41 chrome/browser/installable/installable_manager.h:41: // ...
3 years, 11 months ago (2017-01-16 14:37:52 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2625423002/80001
3 years, 11 months ago (2017-01-16 14:38:20 UTC) #24
commit-bot: I haz the power
3 years, 11 months ago (2017-01-16 15:17:43 UTC) #27
Message was sent while issue was closed.
Committed patchset #4 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/919511bd14650ee9b2dde0411686...

Powered by Google App Engine
This is Rietveld 408576698