Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc

Issue 2625423002: Rename "icon" to "primary icon" in InstallableManager (Closed)
Patch Set: Addressing comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc
diff --git a/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc b/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc
index 155aadaf37afc4bf508c9f326a18e9e2d27eb3ca..a29a5c4b5f6fe48f4d13d7d630cc552d8893bb9c 100644
--- a/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc
+++ b/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc
@@ -47,10 +47,10 @@ InstallableParams ParamsToPerformInstallableCheck(int ideal_icon_size_in_px,
int minimum_icon_size_in_px,
bool check_installable) {
InstallableParams params;
- params.ideal_icon_size_in_px = ideal_icon_size_in_px;
- params.minimum_icon_size_in_px = minimum_icon_size_in_px;
+ params.ideal_primary_icon_size_in_px = ideal_icon_size_in_px;
+ params.minimum_primary_icon_size_in_px = minimum_icon_size_in_px;
params.check_installable = check_installable;
- params.fetch_valid_icon = true;
+ params.fetch_valid_primary_icon = true;
return params;
}
@@ -218,10 +218,10 @@ void AddToHomescreenDataFetcher::OnDidPerformInstallableCheck(
weak_observer_->OnUserTitleAvailable(shortcut_info_.user_title);
- if (data.icon) {
- shortcut_info_.best_icon_url = data.icon_url;
+ if (data.primary_icon) {
+ shortcut_info_.best_icon_url = data.primary_icon_url;
- CreateLauncherIcon(*(data.icon));
+ CreateLauncherIcon(*(data.primary_icon));
return;
}
« no previous file with comments | « chrome/browser/android/webapk/webapk_update_data_fetcher.cc ('k') | chrome/browser/banners/app_banner_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698