Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Unified Diff: chrome/browser/android/webapk/webapk_update_data_fetcher.cc

Issue 2625423002: Rename "icon" to "primary icon" in InstallableManager (Closed)
Patch Set: Addressing comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/webapk/webapk_update_data_fetcher.cc
diff --git a/chrome/browser/android/webapk/webapk_update_data_fetcher.cc b/chrome/browser/android/webapk/webapk_update_data_fetcher.cc
index 935ffa1a941de98c3483a31f3514727c420ab5ed..72d1c1615a8ea86b360d49fb26b51d2d28ead5fd 100644
--- a/chrome/browser/android/webapk/webapk_update_data_fetcher.cc
+++ b/chrome/browser/android/webapk/webapk_update_data_fetcher.cc
@@ -112,12 +112,12 @@ void WebApkUpdateDataFetcher::FetchInstallableData() {
}
InstallableParams params;
- params.ideal_icon_size_in_px =
+ params.ideal_primary_icon_size_in_px =
ShortcutHelper::GetIdealHomescreenIconSizeInPx();
- params.minimum_icon_size_in_px =
+ params.minimum_primary_icon_size_in_px =
ShortcutHelper::GetMinimumHomescreenIconSizeInPx();
params.check_installable = true;
- params.fetch_valid_icon = true;
+ params.fetch_valid_primary_icon = true;
InstallableManager::CreateForWebContents(web_contents());
InstallableManager* installable_manager =
InstallableManager::FromWebContents(web_contents());
@@ -152,15 +152,15 @@ void WebApkUpdateDataFetcher::OnDidGetInstallableData(
info_.UpdateFromManifest(data.manifest);
info_.manifest_url = data.manifest_url;
- info_.best_icon_url = data.icon_url;
- best_icon_ = *data.icon;
+ info_.best_icon_url = data.primary_icon_url;
+ best_icon_ = *data.primary_icon;
icon_hasher_.reset(new WebApkIconHasher());
Profile* profile =
Profile::FromBrowserContext(web_contents()->GetBrowserContext());
icon_hasher_->DownloadAndComputeMurmur2Hash(
profile->GetRequestContext(),
- data.icon_url,
+ data.primary_icon_url,
base::Bind(&WebApkUpdateDataFetcher::OnGotIconMurmur2Hash,
weak_ptr_factory_.GetWeakPtr()));
}
« no previous file with comments | « no previous file | chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698