Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Unified Diff: chrome/browser/banners/app_banner_manager.cc

Issue 2625423002: Rename "icon" to "primary icon" in InstallableManager (Closed)
Patch Set: Addressing comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/banners/app_banner_manager.cc
diff --git a/chrome/browser/banners/app_banner_manager.cc b/chrome/browser/banners/app_banner_manager.cc
index 55e03e54125f80d4a2d922e12309374743c0ca21..f7661ac23a1c3960d42ee9945fae2d100e8ba24b 100644
--- a/chrome/browser/banners/app_banner_manager.cc
+++ b/chrome/browser/banners/app_banner_manager.cc
@@ -42,10 +42,10 @@ InstallableParams ParamsToGetManifest() {
InstallableParams ParamsToPerformInstallableCheck(int ideal_icon_size_in_px,
int minimum_icon_size_in_px) {
InstallableParams params;
- params.ideal_icon_size_in_px = ideal_icon_size_in_px;
- params.minimum_icon_size_in_px = minimum_icon_size_in_px;
+ params.ideal_primary_icon_size_in_px = ideal_icon_size_in_px;
+ params.minimum_primary_icon_size_in_px = minimum_icon_size_in_px;
params.check_installable = true;
- params.fetch_valid_icon = true;
+ params.fetch_valid_primary_icon = true;
return params;
}
@@ -274,11 +274,11 @@ void AppBannerManager::OnDidPerformInstallableCheck(
return;
DCHECK(data.is_installable);
- DCHECK(!data.icon_url.is_empty());
- DCHECK(data.icon);
+ DCHECK(!data.primary_icon_url.is_empty());
+ DCHECK(data.primary_icon);
- icon_url_ = data.icon_url;
- icon_.reset(new SkBitmap(*data.icon));
+ icon_url_ = data.primary_icon_url;
+ icon_.reset(new SkBitmap(*data.primary_icon));
SendBannerPromptRequest();
}
« no previous file with comments | « chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc ('k') | chrome/browser/installable/installable_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698