Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 2625223002: [DevTools] Dedicated frontend for debugging Node. (Closed)

Created:
3 years, 11 months ago by dgozman
Modified:
3 years, 11 months ago
Reviewers:
Tom Sepez, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, jam, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, darin-cc_chromium.org, arv+watch_chromium.org, devtools-reviews_chromium.org, blink-reviews, apavlov+blink_chromium.org, kinuko+watch, pfeldman, blink-worker-reviews_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Dedicated frontend for debugging Node. BUG=635951 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2625223002 Cr-Commit-Position: refs/heads/master@{#444655} Committed: https://chromium.googlesource.com/chromium/src/+/6cbb47c4ee66492694a4798fbbd652046bce0ce0

Patch Set 1 #

Patch Set 2 : test fixes #

Patch Set 3 : fix DCHECK #

Patch Set 4 : test fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+236 lines, -399 lines) Patch
M chrome/browser/devtools/chrome_devtools_manager_delegate.cc View 1 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/devtools/devtools_embedder_message_dispatcher.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/devtools/devtools_embedder_message_dispatcher.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/devtools/devtools_ui_bindings.h View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/devtools/devtools_ui_bindings.cc View 1 2 3 chunks +7 lines, -1 line 0 comments Download
M chrome/browser/devtools/devtools_window.h View 4 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/devtools/devtools_window.cc View 1 2 10 chunks +25 lines, -6 lines 0 comments Download
M chrome/browser/resources/inspect/inspect.css View 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/resources/inspect/inspect.html View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/inspect/inspect.js View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/inspect_ui.cc View 4 chunks +13 lines, -0 lines 0 comments Download
M content/browser/devtools/browser_devtools_agent_host.h View 2 chunks +3 lines, -15 lines 0 comments Download
M content/browser/devtools/browser_devtools_agent_host.cc View 4 chunks +18 lines, -4 lines 0 comments Download
M content/browser/devtools/devtools_session.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/devtools/devtools_session.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M content/browser/devtools/protocol/target_handler.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/devtools/render_frame_devtools_agent_host.cc View 1 2 3 2 chunks +8 lines, -5 lines 0 comments Download
M content/browser/devtools/worker_devtools_agent_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/devtools_agent_host.h View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/debugger-test.js View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/devtools_compatibility.js View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/host/InspectorFrontendHost.js View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/host/InspectorFrontendHostAPI.js View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/main/Main.js View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/SubTargetsManager.js View 8 chunks +23 lines, -123 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/ThreadsSidebarPane.js View 8 chunks +65 lines, -229 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/sourcesPanel.css View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 32 (20 generated)
dgozman
Take a look please. Screenshot in the bug.
3 years, 11 months ago (2017-01-11 23:31:33 UTC) #5
pfeldman
lgtm
3 years, 11 months ago (2017-01-12 00:43:23 UTC) #6
dgozman
Tom, could you please take a look at chrome/browser/devtools/devtools_embedder_message_dispatcher? I'm adding one more method which ...
3 years, 11 months ago (2017-01-13 18:04:39 UTC) #14
Tom Sepez
Code itself looks good, but can you elaborate on "in a controlled fashion"? In other ...
3 years, 11 months ago (2017-01-13 19:00:33 UTC) #15
dgozman
On 2017/01/13 19:00:33, Tom Sepez wrote: > Code itself looks good, but can you elaborate ...
3 years, 11 months ago (2017-01-13 19:29:05 UTC) #16
Tom Sepez
Great. Thanks. LGTM.
3 years, 11 months ago (2017-01-13 21:07:55 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2625223002/40001
3 years, 11 months ago (2017-01-18 19:25:08 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/373236)
3 years, 11 months ago (2017-01-18 22:07:20 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2625223002/60001
3 years, 11 months ago (2017-01-19 00:03:39 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/139596)
3 years, 11 months ago (2017-01-19 01:05:12 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2625223002/60001
3 years, 11 months ago (2017-01-19 05:20:59 UTC) #29
commit-bot: I haz the power
3 years, 11 months ago (2017-01-19 05:36:10 UTC) #32
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/6cbb47c4ee66492694a4798fbbd6...

Powered by Google App Engine
This is Rietveld 408576698