Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(941)

Side by Side Diff: chrome/browser/devtools/devtools_ui_bindings.cc

Issue 2625223002: [DevTools] Dedicated frontend for debugging Node. (Closed)
Patch Set: test fix Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/devtools/devtools_ui_bindings.h" 5 #include "chrome/browser/devtools/devtools_ui_bindings.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <memory> 9 #include <memory>
10 #include <utility> 10 #include <utility>
(...skipping 191 matching lines...) Expand 10 before | Expand all | Expand 10 after
202 ~DefaultBindingsDelegate() override {} 202 ~DefaultBindingsDelegate() override {}
203 203
204 void ActivateWindow() override; 204 void ActivateWindow() override;
205 void CloseWindow() override {} 205 void CloseWindow() override {}
206 void Inspect(scoped_refptr<content::DevToolsAgentHost> host) override {} 206 void Inspect(scoped_refptr<content::DevToolsAgentHost> host) override {}
207 void SetInspectedPageBounds(const gfx::Rect& rect) override {} 207 void SetInspectedPageBounds(const gfx::Rect& rect) override {}
208 void InspectElementCompleted() override {} 208 void InspectElementCompleted() override {}
209 void SetIsDocked(bool is_docked) override {} 209 void SetIsDocked(bool is_docked) override {}
210 void OpenInNewTab(const std::string& url) override; 210 void OpenInNewTab(const std::string& url) override;
211 void SetWhitelistedShortcuts(const std::string& message) override {} 211 void SetWhitelistedShortcuts(const std::string& message) override {}
212 void OpenNodeFrontend() override {}
212 using DispatchCallback = 213 using DispatchCallback =
213 DevToolsEmbedderMessageDispatcher::Delegate::DispatchCallback; 214 DevToolsEmbedderMessageDispatcher::Delegate::DispatchCallback;
214 215
215 void InspectedContentsClosing() override; 216 void InspectedContentsClosing() override;
216 void OnLoadCompleted() override {} 217 void OnLoadCompleted() override {}
217 void ReadyForTest() override {} 218 void ReadyForTest() override {}
218 InfoBarService* GetInfoBarService() override; 219 InfoBarService* GetInfoBarService() override;
219 void RenderProcessGone(bool crashed) override {} 220 void RenderProcessGone(bool crashed) override {}
220 221
221 content::WebContents* web_contents_; 222 content::WebContents* web_contents_;
(...skipping 151 matching lines...) Expand 10 before | Expand all | Expand 10 after
373 std::string sanitized = SanitizeFrontendURL(url, url::kHttpsScheme, 374 std::string sanitized = SanitizeFrontendURL(url, url::kHttpsScheme,
374 kRemoteFrontendDomain, path, true).spec(); 375 kRemoteFrontendDomain, path, true).spec();
375 return net::EscapeQueryParamValue(sanitized, false); 376 return net::EscapeQueryParamValue(sanitized, false);
376 } 377 }
377 378
378 std::string SanitizeFrontendQueryParam( 379 std::string SanitizeFrontendQueryParam(
379 const std::string& key, 380 const std::string& key,
380 const std::string& value) { 381 const std::string& value) {
381 // Convert boolean flags to true. 382 // Convert boolean flags to true.
382 if (key == "can_dock" || key == "debugFrontend" || key == "experiments" || 383 if (key == "can_dock" || key == "debugFrontend" || key == "experiments" ||
383 key == "isSharedWorker" || key == "v8only" || key == "remoteFrontend") 384 key == "isSharedWorker" || key == "v8only" || key == "remoteFrontend" ||
385 key == "nodeFrontend")
384 return "true"; 386 return "true";
385 387
386 // Pass connection endpoints as is. 388 // Pass connection endpoints as is.
387 if (key == "ws" || key == "service-backend") 389 if (key == "ws" || key == "service-backend")
388 return SanitizeEndpoint(value); 390 return SanitizeEndpoint(value);
389 391
390 // Only support undocked for old frontends. 392 // Only support undocked for old frontends.
391 if (key == "dockSide" && value == "undocked") 393 if (key == "dockSide" && value == "undocked")
392 return value; 394 return value;
393 395
(...skipping 574 matching lines...) Expand 10 before | Expand all | Expand 10 after
968 host->Close(); 970 host->Close();
969 } 971 }
970 972
971 void DevToolsUIBindings::OpenRemotePage(const std::string& browser_id, 973 void DevToolsUIBindings::OpenRemotePage(const std::string& browser_id,
972 const std::string& url) { 974 const std::string& url) {
973 if (!remote_targets_handler_) 975 if (!remote_targets_handler_)
974 return; 976 return;
975 remote_targets_handler_->Open(browser_id, url); 977 remote_targets_handler_->Open(browser_id, url);
976 } 978 }
977 979
980 void DevToolsUIBindings::OpenNodeFrontend() {
981 delegate_->OpenNodeFrontend();
982 }
983
978 void DevToolsUIBindings::GetPreferences(const DispatchCallback& callback) { 984 void DevToolsUIBindings::GetPreferences(const DispatchCallback& callback) {
979 const DictionaryValue* prefs = 985 const DictionaryValue* prefs =
980 profile_->GetPrefs()->GetDictionary(prefs::kDevToolsPreferences); 986 profile_->GetPrefs()->GetDictionary(prefs::kDevToolsPreferences);
981 callback.Run(prefs); 987 callback.Run(prefs);
982 } 988 }
983 989
984 void DevToolsUIBindings::SetPreference(const std::string& name, 990 void DevToolsUIBindings::SetPreference(const std::string& name,
985 const std::string& value) { 991 const std::string& value) {
986 DictionaryPrefUpdate update(profile_->GetPrefs(), 992 DictionaryPrefUpdate update(profile_->GetPrefs(),
987 prefs::kDevToolsPreferences); 993 prefs::kDevToolsPreferences);
(...skipping 353 matching lines...) Expand 10 before | Expand all | Expand 10 after
1341 void DevToolsUIBindings::FrontendLoaded() { 1347 void DevToolsUIBindings::FrontendLoaded() {
1342 if (frontend_loaded_) 1348 if (frontend_loaded_)
1343 return; 1349 return;
1344 frontend_loaded_ = true; 1350 frontend_loaded_ = true;
1345 1351
1346 // Call delegate first - it seeds importants bit of information. 1352 // Call delegate first - it seeds importants bit of information.
1347 delegate_->OnLoadCompleted(); 1353 delegate_->OnLoadCompleted();
1348 1354
1349 AddDevToolsExtensionsToClient(); 1355 AddDevToolsExtensionsToClient();
1350 } 1356 }
OLDNEW
« no previous file with comments | « chrome/browser/devtools/devtools_ui_bindings.h ('k') | chrome/browser/devtools/devtools_window.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698