Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(732)

Unified Diff: chrome/browser/devtools/devtools_ui_bindings.cc

Issue 2625223002: [DevTools] Dedicated frontend for debugging Node. (Closed)
Patch Set: test fix Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/devtools/devtools_ui_bindings.h ('k') | chrome/browser/devtools/devtools_window.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/devtools/devtools_ui_bindings.cc
diff --git a/chrome/browser/devtools/devtools_ui_bindings.cc b/chrome/browser/devtools/devtools_ui_bindings.cc
index 2c6c72214bb491ca2fbf25f7ba29c2fab6388f59..aea197f17799bdc717b7b9366d59d0f1eba6b890 100644
--- a/chrome/browser/devtools/devtools_ui_bindings.cc
+++ b/chrome/browser/devtools/devtools_ui_bindings.cc
@@ -209,6 +209,7 @@ class DefaultBindingsDelegate : public DevToolsUIBindings::Delegate {
void SetIsDocked(bool is_docked) override {}
void OpenInNewTab(const std::string& url) override;
void SetWhitelistedShortcuts(const std::string& message) override {}
+ void OpenNodeFrontend() override {}
using DispatchCallback =
DevToolsEmbedderMessageDispatcher::Delegate::DispatchCallback;
@@ -380,7 +381,8 @@ std::string SanitizeFrontendQueryParam(
const std::string& value) {
// Convert boolean flags to true.
if (key == "can_dock" || key == "debugFrontend" || key == "experiments" ||
- key == "isSharedWorker" || key == "v8only" || key == "remoteFrontend")
+ key == "isSharedWorker" || key == "v8only" || key == "remoteFrontend" ||
+ key == "nodeFrontend")
return "true";
// Pass connection endpoints as is.
@@ -975,6 +977,10 @@ void DevToolsUIBindings::OpenRemotePage(const std::string& browser_id,
remote_targets_handler_->Open(browser_id, url);
}
+void DevToolsUIBindings::OpenNodeFrontend() {
+ delegate_->OpenNodeFrontend();
+}
+
void DevToolsUIBindings::GetPreferences(const DispatchCallback& callback) {
const DictionaryValue* prefs =
profile_->GetPrefs()->GetDictionary(prefs::kDevToolsPreferences);
« no previous file with comments | « chrome/browser/devtools/devtools_ui_bindings.h ('k') | chrome/browser/devtools/devtools_window.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698