Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Side by Side Diff: chrome/browser/ui/webui/inspect_ui.cc

Issue 2625223002: [DevTools] Dedicated frontend for debugging Node. (Closed)
Patch Set: test fix Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/inspect_ui.h" 5 #include "chrome/browser/ui/webui/inspect_ui.h"
6 6
7 #include "base/macros.h" 7 #include "base/macros.h"
8 #include "base/memory/ptr_util.h" 8 #include "base/memory/ptr_util.h"
9 #include "chrome/browser/devtools/devtools_targets_ui.h" 9 #include "chrome/browser/devtools/devtools_targets_ui.h"
10 #include "chrome/browser/devtools/devtools_ui_bindings.h" 10 #include "chrome/browser/devtools/devtools_ui_bindings.h"
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
49 const char kLocalHost[] = "localhost"; 49 const char kLocalHost[] = "localhost";
50 50
51 const char kDiscoverUsbDevicesEnabledCommand[] = 51 const char kDiscoverUsbDevicesEnabledCommand[] =
52 "set-discover-usb-devices-enabled"; 52 "set-discover-usb-devices-enabled";
53 const char kPortForwardingEnabledCommand[] = 53 const char kPortForwardingEnabledCommand[] =
54 "set-port-forwarding-enabled"; 54 "set-port-forwarding-enabled";
55 const char kPortForwardingConfigCommand[] = "set-port-forwarding-config"; 55 const char kPortForwardingConfigCommand[] = "set-port-forwarding-config";
56 const char kDiscoverTCPTargetsEnabledCommand[] = 56 const char kDiscoverTCPTargetsEnabledCommand[] =
57 "set-discover-tcp-targets-enabled"; 57 "set-discover-tcp-targets-enabled";
58 const char kTCPDiscoveryConfigCommand[] = "set-tcp-discovery-config"; 58 const char kTCPDiscoveryConfigCommand[] = "set-tcp-discovery-config";
59 const char kOpenNodeFrontendCommand[] = "open-node-frontend";
59 60
60 const char kPortForwardingDefaultPort[] = "8080"; 61 const char kPortForwardingDefaultPort[] = "8080";
61 const char kPortForwardingDefaultLocation[] = "localhost:8080"; 62 const char kPortForwardingDefaultLocation[] = "localhost:8080";
62 63
63 const char kNameField[] = "name"; 64 const char kNameField[] = "name";
64 const char kUrlField[] = "url"; 65 const char kUrlField[] = "url";
65 const char kIsAdditionalField[] = "isAdditional"; 66 const char kIsAdditionalField[] = "isAdditional";
66 67
67 void GetUiDevToolsTargets(base::ListValue& targets) { 68 void GetUiDevToolsTargets(base::ListValue& targets) {
68 for (const auto& client_pair : 69 for (const auto& client_pair :
(...skipping 23 matching lines...) Expand all
92 void HandleInspectAdditionalCommand(const base::ListValue* args); 93 void HandleInspectAdditionalCommand(const base::ListValue* args);
93 void HandleActivateCommand(const base::ListValue* args); 94 void HandleActivateCommand(const base::ListValue* args);
94 void HandleCloseCommand(const base::ListValue* args); 95 void HandleCloseCommand(const base::ListValue* args);
95 void HandleReloadCommand(const base::ListValue* args); 96 void HandleReloadCommand(const base::ListValue* args);
96 void HandleOpenCommand(const base::ListValue* args); 97 void HandleOpenCommand(const base::ListValue* args);
97 void HandleInspectBrowserCommand(const base::ListValue* args); 98 void HandleInspectBrowserCommand(const base::ListValue* args);
98 void HandleBooleanPrefChanged(const char* pref_name, 99 void HandleBooleanPrefChanged(const char* pref_name,
99 const base::ListValue* args); 100 const base::ListValue* args);
100 void HandlePortForwardingConfigCommand(const base::ListValue* args); 101 void HandlePortForwardingConfigCommand(const base::ListValue* args);
101 void HandleTCPDiscoveryConfigCommand(const base::ListValue* args); 102 void HandleTCPDiscoveryConfigCommand(const base::ListValue* args);
103 void HandleOpenNodeFrontendCommand(const base::ListValue* args);
102 104
103 InspectUI* inspect_ui_; 105 InspectUI* inspect_ui_;
104 106
105 DISALLOW_COPY_AND_ASSIGN(InspectMessageHandler); 107 DISALLOW_COPY_AND_ASSIGN(InspectMessageHandler);
106 }; 108 };
107 109
108 void InspectMessageHandler::RegisterMessages() { 110 void InspectMessageHandler::RegisterMessages() {
109 web_ui()->RegisterMessageCallback(kInitUICommand, 111 web_ui()->RegisterMessageCallback(kInitUICommand,
110 base::Bind(&InspectMessageHandler::HandleInitUICommand, 112 base::Bind(&InspectMessageHandler::HandleInitUICommand,
111 base::Unretained(this))); 113 base::Unretained(this)));
(...skipping 21 matching lines...) Expand all
133 web_ui()->RegisterMessageCallback(kPortForwardingConfigCommand, 135 web_ui()->RegisterMessageCallback(kPortForwardingConfigCommand,
134 base::Bind(&InspectMessageHandler::HandlePortForwardingConfigCommand, 136 base::Bind(&InspectMessageHandler::HandlePortForwardingConfigCommand,
135 base::Unretained(this))); 137 base::Unretained(this)));
136 web_ui()->RegisterMessageCallback(kDiscoverTCPTargetsEnabledCommand, 138 web_ui()->RegisterMessageCallback(kDiscoverTCPTargetsEnabledCommand,
137 base::Bind(&InspectMessageHandler::HandleBooleanPrefChanged, 139 base::Bind(&InspectMessageHandler::HandleBooleanPrefChanged,
138 base::Unretained(this), 140 base::Unretained(this),
139 &prefs::kDevToolsDiscoverTCPTargetsEnabled[0])); 141 &prefs::kDevToolsDiscoverTCPTargetsEnabled[0]));
140 web_ui()->RegisterMessageCallback(kTCPDiscoveryConfigCommand, 142 web_ui()->RegisterMessageCallback(kTCPDiscoveryConfigCommand,
141 base::Bind(&InspectMessageHandler::HandleTCPDiscoveryConfigCommand, 143 base::Bind(&InspectMessageHandler::HandleTCPDiscoveryConfigCommand,
142 base::Unretained(this))); 144 base::Unretained(this)));
145 web_ui()->RegisterMessageCallback(kOpenNodeFrontendCommand,
146 base::Bind(&InspectMessageHandler::HandleOpenNodeFrontendCommand,
147 base::Unretained(this)));
143 web_ui()->RegisterMessageCallback(kReloadCommand, 148 web_ui()->RegisterMessageCallback(kReloadCommand,
144 base::Bind(&InspectMessageHandler::HandleReloadCommand, 149 base::Bind(&InspectMessageHandler::HandleReloadCommand,
145 base::Unretained(this))); 150 base::Unretained(this)));
146 web_ui()->RegisterMessageCallback(kOpenCommand, 151 web_ui()->RegisterMessageCallback(kOpenCommand,
147 base::Bind(&InspectMessageHandler::HandleOpenCommand, 152 base::Bind(&InspectMessageHandler::HandleOpenCommand,
148 base::Unretained(this))); 153 base::Unretained(this)));
149 web_ui()->RegisterMessageCallback(kInspectBrowser, 154 web_ui()->RegisterMessageCallback(kInspectBrowser,
150 base::Bind(&InspectMessageHandler::HandleInspectBrowserCommand, 155 base::Bind(&InspectMessageHandler::HandleInspectBrowserCommand,
151 base::Unretained(this))); 156 base::Unretained(this)));
152 } 157 }
(...skipping 99 matching lines...) Expand 10 before | Expand all | Expand 10 after
252 const base::ListValue* args) { 257 const base::ListValue* args) {
253 Profile* profile = Profile::FromWebUI(web_ui()); 258 Profile* profile = Profile::FromWebUI(web_ui());
254 if (!profile) 259 if (!profile)
255 return; 260 return;
256 261
257 const base::ListValue* list_src; 262 const base::ListValue* list_src;
258 if (args->GetSize() == 1 && args->GetList(0, &list_src)) 263 if (args->GetSize() == 1 && args->GetList(0, &list_src))
259 profile->GetPrefs()->Set(prefs::kDevToolsTCPDiscoveryConfig, *list_src); 264 profile->GetPrefs()->Set(prefs::kDevToolsTCPDiscoveryConfig, *list_src);
260 } 265 }
261 266
267 void InspectMessageHandler::HandleOpenNodeFrontendCommand(
268 const base::ListValue* args) {
269 Profile* profile = Profile::FromWebUI(web_ui());
270 if (!profile)
271 return;
272 DevToolsWindow::OpenNodeFrontendWindow(profile);
273 }
274
262 // DevToolsUIBindingsEnabler ---------------------------------------- 275 // DevToolsUIBindingsEnabler ----------------------------------------
263 276
264 class DevToolsUIBindingsEnabler 277 class DevToolsUIBindingsEnabler
265 : public content::WebContentsObserver { 278 : public content::WebContentsObserver {
266 public: 279 public:
267 DevToolsUIBindingsEnabler(WebContents* web_contents, 280 DevToolsUIBindingsEnabler(WebContents* web_contents,
268 const GURL& url); 281 const GURL& url);
269 ~DevToolsUIBindingsEnabler() override {} 282 ~DevToolsUIBindingsEnabler() override {}
270 283
271 DevToolsUIBindings* GetBindings(); 284 DevToolsUIBindings* GetBindings();
(...skipping 339 matching lines...) Expand 10 before | Expand all | Expand 10 after
611 handler->ForceUpdate(); 624 handler->ForceUpdate();
612 } 625 }
613 626
614 void InspectUI::PopulatePortStatus(const base::Value& status) { 627 void InspectUI::PopulatePortStatus(const base::Value& status) {
615 web_ui()->CallJavascriptFunctionUnsafe("populatePortStatus", status); 628 web_ui()->CallJavascriptFunctionUnsafe("populatePortStatus", status);
616 } 629 }
617 630
618 void InspectUI::ShowIncognitoWarning() { 631 void InspectUI::ShowIncognitoWarning() {
619 web_ui()->CallJavascriptFunctionUnsafe("showIncognitoWarning"); 632 web_ui()->CallJavascriptFunctionUnsafe("showIncognitoWarning");
620 } 633 }
OLDNEW
« no previous file with comments | « chrome/browser/resources/inspect/inspect.js ('k') | content/browser/devtools/browser_devtools_agent_host.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698