Apply SVG viewport clips in PaintLayer; paint background of replaced like boxes.

Apply SVG viewport clips in PaintLayer; paint background of replaced like boxes.

This patch:

1. Starts painting the background of LayoutReplaced elements in the background
phase, rather than the foreground phase. This makes them behave like other boxes.

2. Because of 1, we can now treat overflow clips that apply to replaced elements
like other overflow clips; in particular this applies to SVG root viewport clips.
Now these clips are applied in PaintLayer for self-painting PaintLayer SVG
root elements, and BoxClipper otherwise clips them.

3. Replaced outlines already paint in the outline phase; removed unneeded
code in SVGRootPainter related to that.



BUG=680325
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2624383002
Cr-Commit-Position: refs/heads/master@{#443804}
Committed: https://chromium.googlesource.com/chromium/src/+/4180b2e34325e450db3d4feb3c09b58ced38e98a

[chrishtr, 2017-01-12 00:22:23]

Description was changed from

==========
none


none

BUG=
==========

to

==========
none


none

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2017-01-12 00:22:49]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[chrishtr, 2017-01-12 00:23:25]

Description was changed from

==========
none


none

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Apply SVG viewport clips in SPv1.

BUG=680325
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[commit-bot: I haz the power, 2017-01-12 00:23:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 01:29:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 01:29:02]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[chrishtr, 2017-01-13 01:34:45]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-13 01:35:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 02:30:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-13 02:30:12]

Dry run: Try jobs failed on following builders:
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)

[chrishtr, 2017-01-13 21:52:12]

Description was changed from

==========
Apply SVG viewport clips in SPv1.

BUG=680325
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Apply SVG viewport clips in PaintLayer; paint background of replaced like boxes.

This patch:

1. Starts painting the background of LayoutReplaced elements in the background
phase, rather than the foreground phase. This makes them behave like other
boxes.

2. Because of 1, we can now treat overflow clips that apply to replaced elements
like other overflow clips; in particular this applies to SVG root viewport
clips.
Now these clips are applied in PaintLayer for self-painting PaintLayer SVG
root elements, and BoxClipper otherwise clips them.

3. Replaced outlines already paint in the outline phase; removed unneeded
code in SVGRootPainter related to that.



BUG=680325
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2017-01-13 21:53:30]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[chrishtr, 2017-01-13 21:53:35]

chrishtr@chromium.org changed reviewers:
+ pdr@chromium.org

[chrishtr, 2017-01-13 21:53:35]

https://codereview.chromium.org/2624383002/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/svg/filters/svg-filter-child-box-reflect.html
(right):

https://codereview.chromium.org/2624383002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/svg/filters/svg-filter-child-box-reflect.html:14:
overflow: visible;
Added overflow: visible to this and one other test, because otherwise the
SVG root viewport clip will apply. The implementation of box reflect for
SVG roots was previously broken w.r.t. clipping.

[commit-bot: I haz the power, 2017-01-13 21:54:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pdr., 2017-01-13 22:09:37]

https://codereview.chromium.org/2624383002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/BoxClipper.cpp (left):

https://codereview.chromium.org/2624383002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/BoxClipper.cpp:22: if (box.isSVGRoot() &&
toLayoutSVGRoot(box).shouldApplyViewportClip())
Please move this down a few lines.

[chrishtr, 2017-01-13 22:14:22]

https://codereview.chromium.org/2624383002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/BoxClipper.cpp (left):

https://codereview.chromium.org/2624383002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/BoxClipper.cpp:22: if (box.isSVGRoot() &&
toLayoutSVGRoot(box).shouldApplyViewportClip())
On 2017/01/13 at 22:09:36, pdr. wrote:
> Please move this down a few lines.

Done. Also added a comment inspired by your catch.

[chrishtr, 2017-01-13 22:14:41]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-13 22:15:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pdr., 2017-01-13 22:58:18]

LGTM

https://codereview.chromium.org/2624383002/diff/80001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/TestExpectations (right):

https://codereview.chromium.org/2624383002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/TestExpectations:1154: crbug.com/680325
svg/custom/mouse-move-on-svg-container-standalone.svg [ NeedsRebaseline ]
Can you include these in the patch using the fancy new baseline-off-the-bots
technology?

[commit-bot: I haz the power, 2017-01-13 23:39:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-13 23:39:49]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[chrishtr, 2017-01-14 16:27:03]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2017-01-14 16:27:03]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2624383002/#ps100001
(title: "none")

[commit-bot: I haz the power, 2017-01-14 16:27:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-14 17:32:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-14 17:32:52]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[chrishtr, 2017-01-14 22:02:13]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2017-01-14 22:02:14]

Fixed a couple more unittests that weren't expecting the new clip.

[chrishtr, 2017-01-14 22:02:15]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2624383002/#ps120001
(title: "none")

[commit-bot: I haz the power, 2017-01-14 22:02:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-14 23:50:30]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1484431333969450,
"parent_rev": "c1f4d0f3790af6f5f3e24d0c0d6092f6525ddd5a", "commit_rev":
"4180b2e34325e450db3d4feb3c09b58ced38e98a"}

[commit-bot: I haz the power, 2017-01-14 23:51:06]

Description was changed from

==========
Apply SVG viewport clips in PaintLayer; paint background of replaced like boxes.

This patch:

1. Starts painting the background of LayoutReplaced elements in the background
phase, rather than the foreground phase. This makes them behave like other
boxes.

2. Because of 1, we can now treat overflow clips that apply to replaced elements
like other overflow clips; in particular this applies to SVG root viewport
clips.
Now these clips are applied in PaintLayer for self-painting PaintLayer SVG
root elements, and BoxClipper otherwise clips them.

3. Replaced outlines already paint in the outline phase; removed unneeded
code in SVGRootPainter related to that.



BUG=680325
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Apply SVG viewport clips in PaintLayer; paint background of replaced like boxes.

This patch:

1. Starts painting the background of LayoutReplaced elements in the background
phase, rather than the foreground phase. This makes them behave like other
boxes.

2. Because of 1, we can now treat overflow clips that apply to replaced elements
like other overflow clips; in particular this applies to SVG root viewport
clips.
Now these clips are applied in PaintLayer for self-painting PaintLayer SVG
root elements, and BoxClipper otherwise clips them.

3. Replaced outlines already paint in the outline phase; removed unneeded
code in SVGRootPainter related to that.



BUG=680325
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2624383002
Cr-Commit-Position: refs/heads/master@{#443804}
Committed:
https://chromium.googlesource.com/chromium/src/+/4180b2e34325e450db3d4feb3c09...
==========

[commit-bot: I haz the power, 2017-01-14 23:51:07]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/4180b2e34325e450db3d4feb3c09...