third_party/WebKit/Source/core/paint/PaintLayerPainterTest.cpp - Issue 2624383002: Apply SVG viewport clips in PaintLayer; paint background of replaced like boxes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayerPainterTest.cpp

Issue 2624383002: Apply SVG viewport clips in PaintLayer; paint background of replaced like boxes. (Closed)

Patch Set: none Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/paint/PaintLayerClipperTest.cpp ('k') | third_party/WebKit/Source/core/paint/ReplacedPainter.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/PaintLayerPainterTest.cpp

diff --git a/third_party/WebKit/Source/core/paint/PaintLayerPainterTest.cpp b/third_party/WebKit/Source/core/paint/PaintLayerPainterTest.cpp

index 4bdc06b35a5bcb71b1adc93d9bf54dbe4fffc826..5d9d39d7d4b3a543c444c81caf86a8ecbfd3f0cf 100644

--- a/third_party/WebKit/Source/core/paint/PaintLayerPainterTest.cpp

+++ b/third_party/WebKit/Source/core/paint/PaintLayerPainterTest.cpp

@@ -223,11 +223,6 @@ TEST_P(PaintLayerPainterTest, CachedSubsequenceForSVGRoot) {

LayoutObject& rect = *document().getElementById("rect")->layoutObject();

LayoutObject& div = *document().getElementById("div")->layoutObject();

- DisplayItem::Type clipBoxBegin =

- DisplayItem::paintPhaseToClipBoxType(PaintPhaseForeground);

- DisplayItem::Type clipBoxEnd =

- DisplayItem::clipTypeToEndClipType(clipBoxBegin);

if (RuntimeEnabledFeatures::slimmingPaintV2Enabled()) {

if (RuntimeEnabledFeatures::rootLayerScrollingEnabled()) {

// SPv2 slips the clip box (see BoxClipper).

@@ -269,11 +264,12 @@ TEST_P(PaintLayerPainterTest, CachedSubsequenceForSVGRoot) {

TestDisplayItem(layoutView(), documentBackgroundType),

TestDisplayItem(htmlLayer, DisplayItem::kSubsequence),

TestDisplayItem(svgLayer, DisplayItem::kSubsequence),

- TestDisplayItem(svg, clipBoxBegin),

+ TestDisplayItem(svg, DisplayItem::kClipLayerForeground),

TestDisplayItem(svg, DisplayItem::kBeginTransform),

TestDisplayItem(rect, foregroundType),

TestDisplayItem(svg, DisplayItem::kEndTransform),

- TestDisplayItem(svg, clipBoxEnd),

+ TestDisplayItem(svg, DisplayItem::clipTypeToEndClipType(

+ DisplayItem::kClipLayerForeground)),

TestDisplayItem(svgLayer, DisplayItem::kEndSubsequence),

TestDisplayItem(htmlLayer, DisplayItem::kEndSubsequence));

}

@@ -337,11 +333,12 @@ TEST_P(PaintLayerPainterTest, CachedSubsequenceForSVGRoot) {