Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(666)

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayerClipperTest.cpp

Issue 2624383002: Apply SVG viewport clips in PaintLayer; paint background of replaced like boxes. (Closed)
Patch Set: none Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/PaintLayerClipperTest.cpp
diff --git a/third_party/WebKit/Source/core/paint/PaintLayerClipperTest.cpp b/third_party/WebKit/Source/core/paint/PaintLayerClipperTest.cpp
index 951d9e3409403a1c36f6f97f1596053d2d329dbd..43dfa47027829975f6aeafcce8f838720ea4d7f1 100644
--- a/third_party/WebKit/Source/core/paint/PaintLayerClipperTest.cpp
+++ b/third_party/WebKit/Source/core/paint/PaintLayerClipperTest.cpp
@@ -50,12 +50,8 @@ TEST_P(PaintLayerClipperTest, LayoutSVGRoot) {
targetPaintLayer->clipper().calculateRects(
context, LayoutRect(LayoutRect::infiniteIntRect()), layerBounds,
backgroundRect, foregroundRect);
- EXPECT_EQ(LayoutRect(LayoutRect::infiniteIntRect()), backgroundRect.rect());
- // TODO(chrishtr): the behavior for SPv2 is actually correct, since the
- // svg root clip should be applied to the foreground rect. See
- // crbug.com/680325.
- if (!RuntimeEnabledFeatures::slimmingPaintV2Enabled())
- EXPECT_EQ(LayoutRect(LayoutRect::infiniteIntRect()), foregroundRect.rect());
+ EXPECT_EQ(LayoutRect(8, 8, 200, 300), backgroundRect.rect());
+ EXPECT_EQ(LayoutRect(8, 8, 200, 300), foregroundRect.rect());
EXPECT_EQ(LayoutRect(8, 8, 200, 300), layerBounds);
}

Powered by Google App Engine
This is Rietveld 408576698