Apply SVG viewport clips in PaintLayer; paint background of replaced like boxes.

third_party/WebKit/Source/core/paint/BoxClipper.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/paint/BoxClipper.h"
 
 #include "core/layout/LayoutBox.h"
 #include "core/layout/svg/LayoutSVGRoot.h"
 #include "core/paint/ObjectPaintProperties.h"
 #include "core/paint/PaintInfo.h"
 #include "core/paint/PaintLayer.h"
 #include "platform/RuntimeEnabledFeatures.h"
 #include "platform/graphics/GraphicsLayer.h"
 #include "platform/graphics/paint/ClipDisplayItem.h"
 #include "platform/graphics/paint/PaintController.h"
 
 namespace blink {
 
 static bool boxNeedsClip(const LayoutBox& box) {
   if (box.hasControlClip())
     return true;
-  if (box.isSVGRoot() && toLayoutSVGRoot(box).shouldApplyViewportClip())

[pdr., 2017/01/13 22:09:36]

Please move this down a few lines.

[chrishtr, 2017/01/13 22:14:22]

Done. Also added a comment inspired by your catch.

-    return true;
   if (box.hasLayer() && box.layer()->isSelfPaintingLayer())
     return false;
   return box.hasOverflowClip() || box.styleRef().containsPaint();
 }
 
 DISABLE_CFI_PERF
 BoxClipper::BoxClipper(const LayoutBox& box,
                        const PaintInfo& paintInfo,
                        const LayoutPoint& accumulatedOffset,
                        ContentsClipBehavior contentsClipBehavior)
@@ skipping 64 matching lines @@
 BoxClipper::~BoxClipper() {
   if (m_clipType == DisplayItem::kUninitializedType)
     return;
 
   DCHECK(boxNeedsClip(m_box));
   m_paintInfo.context.getPaintController().endItem<EndClipDisplayItem>(
       m_box, DisplayItem::clipTypeToEndClipType(m_clipType));
 }
 
 }  // namespace blink