Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issue 2624033002: Tolerate a null WebScheduler in utility process V8 initialization (Closed)

Created:
3 years, 11 months ago by Ken Rockot(use gerrit already)
Modified:
3 years, 11 months ago
CC:
blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Tolerate a null scheduler in V8 initialization Some utility processes need to initailize Blink and V8, and V8 initialization now assumes the main thread provides a scheduler; but a utility process' main thread does not in fact provide one. This eliminates the recently introduced assumption of a non-null scheduler, defaulting to the previous behavior (using the current ThreadTaskRunnerHandle) when no scheduler is provided. BUG=679911 R=jochen@chromium.org Review-Url: https://codereview.chromium.org/2624033002 Cr-Commit-Position: refs/heads/master@{#442901} Committed: https://chromium.googlesource.com/chromium/src/+/7b9e6bc428d965901cec2999f5ed0933b81bdd29

Patch Set 1 #

Total comments: 4

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M gin/per_isolate_data.cc View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp View 1 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 20 (13 generated)
Ken Rockot(use gerrit already)
jochen@ please take a look as OWNER for all; altimin@ FYI
3 years, 11 months ago (2017-01-10 23:49:10 UTC) #5
haraken
LGTM with a comment. https://codereview.chromium.org/2624033002/diff/1/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp File third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp (right): https://codereview.chromium.org/2624033002/diff/1/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp#newcode395 third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp:395: // NOTE: Some threads don't ...
3 years, 11 months ago (2017-01-10 23:56:59 UTC) #7
Ken Rockot(use gerrit already)
thanks! jochen@ just for gin/ then :) https://codereview.chromium.org/2624033002/diff/1/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp File third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp (right): https://codereview.chromium.org/2624033002/diff/1/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp#newcode395 third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp:395: // NOTE: ...
3 years, 11 months ago (2017-01-11 00:22:40 UTC) #10
jochen (gone - plz use gerrit)
lgtm
3 years, 11 months ago (2017-01-11 09:54:34 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2624033002/20001
3 years, 11 months ago (2017-01-11 14:42:57 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/7b9e6bc428d965901cec2999f5ed0933b81bdd29
3 years, 11 months ago (2017-01-11 14:48:23 UTC) #19
altimin
3 years, 11 months ago (2017-01-12 11:13:24 UTC) #20
Message was sent while issue was closed.
lgtm, thanks for fixing this.

Powered by Google App Engine
This is Rietveld 408576698