Tolerate a null WebScheduler in utility process V8 initialization

third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 374 matching lines @@
 
   WTF::ArrayBufferContents::initialize(adjustAmountOfExternalAllocatedMemory);
 
   DEFINE_STATIC_LOCAL(ArrayBufferAllocator, arrayBufferAllocator, ());
   auto v8ExtrasMode = RuntimeEnabledFeatures::experimentalV8ExtrasEnabled()
                           ? gin::IsolateHolder::kStableAndExperimentalV8Extras
                           : gin::IsolateHolder::kStableV8Extras;
   gin::IsolateHolder::Initialize(gin::IsolateHolder::kNonStrictMode,
                                  v8ExtrasMode, &arrayBufferAllocator);
 
+  // NOTE: Some threads don't have a scheduler.

[haraken, 2017/01/10 23:56:58]

Clarify what the threads are.

[Ken Rockot(use gerrit already), 2017/01/11 00:22:39]

done

   WebScheduler* scheduler = Platform::current()->currentThread()->scheduler();
-  v8::Isolate* isolate =
-      V8PerIsolateData::initialize(scheduler->timerTaskRunner());
+  v8::Isolate* isolate = V8PerIsolateData::initialize(
+      scheduler ? scheduler->timerTaskRunner() : nullptr);

[haraken, 2017/01/10 23:56:58]

I'd prefer passing Platform::current()->currentThread()->timerTaskRunner()
instead of passing nullptr.

[Ken Rockot(use gerrit already), 2017/01/11 00:22:39]

done (getWebTaskRunner)

 
   initializeV8Common(isolate);
 
   isolate->SetOOMErrorHandler(reportOOMErrorInMainThread);
   isolate->SetFatalErrorHandler(reportFatalErrorInMainThread);
   isolate->AddMessageListenerWithErrorLevel(
       messageHandlerInMainThread,
       v8::Isolate::kMessageError | v8::Isolate::kMessageWarning |
           v8::Isolate::kMessageInfo | v8::Isolate::kMessageDebug |
           v8::Isolate::kMessageLog);
@@ skipping 108 matching lines @@
           v8::Isolate::kMessageLog);
   isolate->SetFatalErrorHandler(reportFatalErrorInWorker);
 
   uint32_t here;
   isolate->SetStackLimit(reinterpret_cast<uintptr_t>(&here) -
                          kWorkerMaxStackSize);
   isolate->SetPromiseRejectCallback(promiseRejectHandlerInWorker);
 }
 
 }  // namespace blink