Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1301)

Side by Side Diff: third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp

Issue 2624033002: Tolerate a null WebScheduler in utility process V8 initialization (Closed)
Patch Set: . Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 static void beforeCallEnteredCallback(v8::Isolate* isolate) { 48 static void beforeCallEnteredCallback(v8::Isolate* isolate) {
49 RELEASE_ASSERT(!ScriptForbiddenScope::isScriptForbidden()); 49 RELEASE_ASSERT(!ScriptForbiddenScope::isScriptForbidden());
50 } 50 }
51 51
52 static void microtasksCompletedCallback(v8::Isolate* isolate) { 52 static void microtasksCompletedCallback(v8::Isolate* isolate) {
53 V8PerIsolateData::from(isolate)->runEndOfScopeTasks(); 53 V8PerIsolateData::from(isolate)->runEndOfScopeTasks();
54 } 54 }
55 55
56 V8PerIsolateData::V8PerIsolateData(WebTaskRunner* taskRunner) 56 V8PerIsolateData::V8PerIsolateData(WebTaskRunner* taskRunner)
57 : m_isolateHolder(WTF::makeUnique<gin::IsolateHolder>( 57 : m_isolateHolder(WTF::makeUnique<gin::IsolateHolder>(
58 taskRunner->toSingleThreadTaskRunner())), 58 taskRunner ? taskRunner->toSingleThreadTaskRunner() : nullptr)),
59 m_stringCache(WTF::wrapUnique(new StringCache(isolate()))), 59 m_stringCache(WTF::wrapUnique(new StringCache(isolate()))),
60 m_hiddenValue(V8HiddenValue::create()), 60 m_hiddenValue(V8HiddenValue::create()),
61 m_privateProperty(V8PrivateProperty::create()), 61 m_privateProperty(V8PrivateProperty::create()),
62 m_constructorMode(ConstructorMode::CreateNewObject), 62 m_constructorMode(ConstructorMode::CreateNewObject),
63 m_useCounterDisabled(false), 63 m_useCounterDisabled(false),
64 m_isHandlingRecursionLevelError(false), 64 m_isHandlingRecursionLevelError(false),
65 m_isReportingException(false) { 65 m_isReportingException(false) {
66 // FIXME: Remove once all v8::Isolate::GetCurrent() calls are gone. 66 // FIXME: Remove once all v8::Isolate::GetCurrent() calls are gone.
67 isolate()->Enter(); 67 isolate()->Enter();
68 isolate()->AddBeforeCallEnteredCallback(&beforeCallEnteredCallback); 68 isolate()->AddBeforeCallEnteredCallback(&beforeCallEnteredCallback);
(...skipping 322 matching lines...) Expand 10 before | Expand all | Expand 10 after
391 391
392 void V8PerIsolateData::addActiveScriptWrappable( 392 void V8PerIsolateData::addActiveScriptWrappable(
393 ActiveScriptWrappableBase* wrappable) { 393 ActiveScriptWrappableBase* wrappable) {
394 if (!m_activeScriptWrappables) 394 if (!m_activeScriptWrappables)
395 m_activeScriptWrappables = new ActiveScriptWrappableSet(); 395 m_activeScriptWrappables = new ActiveScriptWrappableSet();
396 396
397 m_activeScriptWrappables->add(wrappable); 397 m_activeScriptWrappables->add(wrappable);
398 } 398 }
399 399
400 } // namespace blink 400 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698