third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp - Issue 2624033002: Tolerate a null WebScheduler in utility process V8 initialization

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp

Issue 2624033002: Tolerate a null WebScheduler in utility process V8 initialization (Closed)

Patch Set: . Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp b/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp

index e6e7ce8ed3835089017642f63ae9bedf72b2b30e..a5d8814c681efc2570fa75ffa2984d286376de37 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp

@@ -55,7 +55,7 @@ static void microtasksCompletedCallback(v8::Isolate* isolate) {

V8PerIsolateData::V8PerIsolateData(WebTaskRunner* taskRunner)

: m_isolateHolder(WTF::makeUnique<gin::IsolateHolder>(

- taskRunner->toSingleThreadTaskRunner())),

+ taskRunner ? taskRunner->toSingleThreadTaskRunner() : nullptr)),

m_stringCache(WTF::wrapUnique(new StringCache(isolate()))),

m_hiddenValue(V8HiddenValue::create()),

m_privateProperty(V8PrivateProperty::create()),

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp ('k') | no next file » | no next file with comments »