Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2623743002: DevTools: extract modules (non-extensions) (Closed)

Created:
3 years, 11 months ago by chenwilliam
Modified:
3 years, 11 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: extract modules (non-extensions) This needs to land prior to my CL for speeding up closure by enforcing dependencies by poisoning namespaces: https://codereview.chromium.org/2588843002 BUG=none Review-Url: https://codereview.chromium.org/2623743002 Cr-Commit-Position: refs/heads/master@{#442706} Committed: https://chromium.googlesource.com/chromium/src/+/17e9d90be4a86c8f884cbe4fd072fc9e95391f4b

Patch Set 1 #

Patch Set 2 : w/ artifact changes #

Patch Set 3 : rebase #

Patch Set 4 : fix #

Patch Set 5 : rebaseline #

Total comments: 4

Patch Set 6 : rebaseline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1176 lines, -12463 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/network/network-columns-sorted.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/network/network-columns-visible.html View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/components/cookies-table.html View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/components/datagrid.html View 1 3 chunks +11 lines, -11 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/components/datagrid-autosize.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/components/datagrid-test.js View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/components/viewport-datagrid.html View 1 4 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-3/spectrum.html View 1 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-3/spectrum-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/initial-modules-load-expected.txt View 1 2 3 4 5 7 chunks +14 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/profiler/heap-snapshot-test.js View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/color-swatch-position.html View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/last-execution-context.html View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-window-filter.html View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/BUILD.gn View 1 2 3 4 5 14 chunks +38 lines, -38 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/Tests.js View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/animation/AnimationUI.js View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/color_picker/Spectrum.js View 1 29 chunks +54 lines, -54 lines 0 comments Download
A third_party/WebKit/Source/devtools/front_end/color_picker/module.json View 1 1 chunk +12 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/color_picker/spectrum.css View 1 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/components/ExecutionContextSelector.js View 1 1 chunk +0 lines, -205 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/components/ShortcutsScreen.js View 1 1 chunk +0 lines, -486 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/components/Spectrum.js View 1 1 chunk +0 lines, -1058 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components/module.json View 1 2 chunks +1 line, -5 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/components/spectrum.css View 1 1 chunk +0 lines, -420 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/components_lazy/CookiesTable.js View 1 1 chunk +0 lines, -315 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/components_lazy/FilmStripModel.js View 1 1 chunk +0 lines, -148 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/components_lazy/FilmStripView.js View 1 1 chunk +0 lines, -311 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/components_lazy/filmStripDialog.css View 1 1 chunk +0 lines, -29 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/components_lazy/filmStripView.css View 1 1 chunk +0 lines, -73 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/components_lazy/module.json View 1 1 chunk +0 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/console/module.json View 1 5 chunks +37 lines, -10 lines 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/cookie_table/CookiesTable.js View 1 8 chunks +28 lines, -16 lines 0 comments Download
A third_party/WebKit/Source/devtools/front_end/cookie_table/module.json View 1 1 chunk +10 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/data_grid/DataGrid.js View 1 35 chunks +66 lines, -66 lines 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/data_grid/ShowMoreDataGridNode.js View 1 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/data_grid/SortableDataGrid.js View 1 10 chunks +22 lines, -21 lines 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/data_grid/ViewportDataGrid.js View 1 8 chunks +16 lines, -16 lines 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/data_grid/dataGrid.css View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/WebKit/Source/devtools/front_end/data_grid/module.json View 1 1 chunk +14 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/ColorSwatchPopoverIcon.js View 1 9 chunks +17 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/ComputedStyleWidget.js View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js View 1 4 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/module.json View 1 7 chunks +66 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/externs.js View 2 chunks +8 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/inline_editor/BezierEditor.js View 1 7 chunks +12 lines, -12 lines 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/inline_editor/BezierUI.js View 1 3 chunks +3 lines, -3 lines 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/inline_editor/CSSShadowEditor.js View 1 16 chunks +43 lines, -41 lines 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/inline_editor/ColorSwatch.js View 1 9 chunks +26 lines, -22 lines 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/inline_editor/SwatchPopoverHelper.js View 1 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/inline_editor/bezierEditor.css View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/inline_editor/bezierSwatch.css View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/inline_editor/colorSwatch.css View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/inline_editor/cssShadowEditor.css View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/inline_editor/cssShadowSwatch.css View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/WebKit/Source/devtools/front_end/inline_editor/module.json View 1 1 chunk +19 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/inspector.json View 1 2 3 4 5 2 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/layer_viewer/PaintProfilerView.js View 1 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/layer_viewer/TransformController.js View 1 1 chunk +9 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/layer_viewer/module.json View 1 1 chunk +0 lines, -1 line 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/main/ExecutionContextSelector.js View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/main/Main.js View 1 4 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/main/module.json View 1 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/EventSourceMessagesView.js View 1 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js View 1 14 chunks +20 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/NetworkOverview.js View 1 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js View 1 8 chunks +14 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/NetworkTimeCalculator.js View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/RequestCookiesView.js View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/RequestTimingView.js View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js View 1 4 chunks +15 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/module.json View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/perf_ui/ChartViewport.js View 1 2 chunks +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/perf_ui/FilmStripView.js View 1 13 chunks +24 lines, -24 lines 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/perf_ui/FlameChart.js View 1 2 3 4 5 22 chunks +43 lines, -42 lines 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/perf_ui/OverviewGrid.js View 1 12 chunks +25 lines, -25 lines 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/perf_ui/PieChart.js View 1 2 chunks +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/perf_ui/TimelineGrid.js View 1 6 chunks +9 lines, -9 lines 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/perf_ui/TimelineOverviewPane.js View 1 15 chunks +22 lines, -22 lines 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/perf_ui/filmStripDialog.css View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/perf_ui/filmStripView.css View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/perf_ui/flameChart.css View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/perf_ui/module.json View 1 1 chunk +16 lines, -1 line 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/perf_ui/overviewGrid.css View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/perf_ui/pieChart.css View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/perf_ui/timelineGrid.css View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileFlameChart.js View 1 9 chunks +19 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileView.js View 1 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/profiler/HeapProfileView.js View 1 4 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotDataGrids.js View 1 19 chunks +24 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotGridNodes.js View 1 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotView.js View 1 13 chunks +19 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/profiler/ProfileDataGrid.js View 1 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/profiler/ProfileView.js View 1 3 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/profiler/module.json View 1 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/ApplicationCacheItemsView.js View 1 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/CookieItemsView.js View 1 3 chunks +3 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/DOMStorageItemsView.js View 1 4 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/DatabaseQueryView.js View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/DatabaseTableView.js View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/IndexedDBViews.js View 1 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkerCacheViews.js View 1 3 chunks +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/module.json View 1 1 chunk +10 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/sdk/FilmStripModel.js View 1 7 chunks +20 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/module.json View 1 4 chunks +26 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/CSSSourceFrame.js View 1 6 chunks +15 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js View 1 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js View 1 1 chunk +8 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/module.json View 1 2 3 4 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/CountersGraph.js View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineEventOverview.js View 1 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js View 1 8 chunks +15 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js View 1 8 chunks +16 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineNetworkFlameChart.js View 1 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js View 1 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js View 1 2 13 chunks +22 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js View 1 4 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/module.json View 1 1 chunk +2 lines, -3 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/ui/BezierEditor.js View 1 1 chunk +0 lines, -271 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/ui/BezierUI.js View 1 1 chunk +0 lines, -128 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/ui/CSSShadowEditor.js View 1 1 chunk +0 lines, -429 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/ui/ColorSwatch.js View 1 1 chunk +0 lines, -291 lines 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/ui/ShortcutsScreen.js View 1 7 chunks +63 lines, -75 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/ui/SwatchPopoverHelper.js View 1 1 chunk +0 lines, -113 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/ui/bezierEditor.css View 1 1 chunk +0 lines, -195 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/ui/bezierSwatch.css View 1 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/ui/colorSwatch.css View 1 1 chunk +0 lines, -35 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/ui/cssShadowEditor.css View 1 1 chunk +0 lines, -98 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/ui/cssShadowSwatch.css View 1 1 chunk +0 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/module.json View 1 2 3 4 5 3 chunks +2 lines, -11 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/ui_lazy/ChartViewport.js View 1 1 chunk +0 lines, -445 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/ui_lazy/DataGrid.js View 1 1 chunk +0 lines, -1971 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/ui_lazy/FlameChart.js View 1 2 3 4 5 1 chunk +0 lines, -1524 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/ui_lazy/OverviewGrid.js View 1 1 chunk +0 lines, -456 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/ui_lazy/PieChart.js View 1 1 chunk +0 lines, -116 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/ui_lazy/ShowMoreDataGridNode.js View 1 1 chunk +0 lines, -143 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/ui_lazy/SortableDataGrid.js View 1 1 chunk +0 lines, -174 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/ui_lazy/TimelineGrid.js View 1 1 chunk +0 lines, -295 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/ui_lazy/TimelineOverviewPane.js View 1 1 chunk +0 lines, -606 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/ui_lazy/ViewportDataGrid.js View 1 1 chunk +0 lines, -481 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/ui_lazy/dataGrid.css View 1 1 chunk +0 lines, -255 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/ui_lazy/flameChart.css View 1 2 3 4 5 1 chunk +0 lines, -114 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/ui_lazy/module.json View 1 2 3 4 1 chunk +0 lines, -29 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/ui_lazy/overviewGrid.css View 1 1 chunk +0 lines, -67 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/ui_lazy/pieChart.css View 1 1 chunk +0 lines, -26 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/ui_lazy/timelineGrid.css View 1 1 chunk +0 lines, -67 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/unit_test_runner.json View 1 2 3 4 5 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/scripts/extract_module/extract_module.js View 2 chunks +50 lines, -83 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
chenwilliam
PTAL.
3 years, 11 months ago (2017-01-10 17:42:20 UTC) #3
dgozman
Looks good at quick glance, deferring to Pavel.
3 years, 11 months ago (2017-01-10 18:28:17 UTC) #4
pfeldman
lgtm % comments https://codereview.chromium.org/2623743002/diff/80001/third_party/WebKit/Source/devtools/front_end/components_lazy/module.json File third_party/WebKit/Source/devtools/front_end/components_lazy/module.json (left): https://codereview.chromium.org/2623743002/diff/80001/third_party/WebKit/Source/devtools/front_end/components_lazy/module.json#oldcode5 third_party/WebKit/Source/devtools/front_end/components_lazy/module.json:5: "sources", This might conflict with recent ...
3 years, 11 months ago (2017-01-10 18:45:35 UTC) #5
chenwilliam
I rebaselined. https://codereview.chromium.org/2623743002/diff/80001/third_party/WebKit/Source/devtools/front_end/components_lazy/module.json File third_party/WebKit/Source/devtools/front_end/components_lazy/module.json (left): https://codereview.chromium.org/2623743002/diff/80001/third_party/WebKit/Source/devtools/front_end/components_lazy/module.json#oldcode5 third_party/WebKit/Source/devtools/front_end/components_lazy/module.json:5: "sources", On 2017/01/10 18:45:35, pfeldman wrote: > ...
3 years, 11 months ago (2017-01-10 19:37:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2623743002/100001
3 years, 11 months ago (2017-01-10 22:02:53 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 22:13:26 UTC) #16
Message was sent while issue was closed. 
Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/17e9d90be4a86c8f884cbe4fd072...

Powered by Google App Engine
This is Rietveld 408576698