third_party/WebKit/Source/devtools/front_end/network/NetworkOverview.js - Issue 2623743002: DevTools: extract modules (non-extensions)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkOverview.js

Issue 2623743002: DevTools: extract modules (non-extensions) (Closed)

Patch Set: rebaseline Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js ('k') | third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/network/NetworkOverview.js

diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkOverview.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkOverview.js

index a283e507616adee1e0ce55fb8725b2713204113f..f8d029629c515fa6b3b850257a874217969dd8bf 100644

--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkOverview.js

+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkOverview.js

@@ -4,7 +4,7 @@

/**

* @unrestricted

-Network.NetworkOverview = class extends UI.TimelineOverviewBase {

+Network.NetworkOverview = class extends PerfUI.TimelineOverviewBase {

constructor() {

super();

this.element.classList.add('network-overview');

@@ -23,7 +23,7 @@ Network.NetworkOverview = class extends UI.TimelineOverviewBase {

}

/**

- * @param {?Components.FilmStripModel} filmStripModel

+ * @param {?SDK.FilmStripModel} filmStripModel

setFilmStripModel(filmStripModel) {

this._filmStripModel = filmStripModel;

@@ -112,7 +112,7 @@ Network.NetworkOverview = class extends UI.TimelineOverviewBase {

* @override

reset() {

- /** @type {?Components.FilmStripModel} */

+ /** @type {?SDK.FilmStripModel} */

this._filmStripModel = null;

/** @type {number} */