third_party/WebKit/Source/devtools/front_end/timeline/CountersGraph.js - Issue 2623743002: DevTools: extract modules (non-extensions)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/CountersGraph.js

Issue 2623743002: DevTools: extract modules (non-extensions) (Closed)

Patch Set: rebaseline Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sources/module.json ('k') | third_party/WebKit/Source/devtools/front_end/timeline/TimelineEventOverview.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/timeline/CountersGraph.js

diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/CountersGraph.js b/third_party/WebKit/Source/devtools/front_end/timeline/CountersGraph.js

index 694eb94f115b212e86b198ede67eeccdb64d1152..0607ccbc1caef3217122f5797accacbfa0c21f1e 100644

--- a/third_party/WebKit/Source/devtools/front_end/timeline/CountersGraph.js

+++ b/third_party/WebKit/Source/devtools/front_end/timeline/CountersGraph.js

@@ -67,7 +67,7 @@ Timeline.CountersGraph = class extends UI.VBox {

this._canvasContainer.addEventListener('mouseleave', this._onMouseLeave.bind(this), true);

this._canvasContainer.addEventListener('click', this._onClick.bind(this), true);

// We create extra timeline grid here to reuse its event dividers.

- this._timelineGrid = new UI.TimelineGrid();

+ this._timelineGrid = new PerfUI.TimelineGrid();

this._canvasContainer.appendChild(this._timelineGrid.dividersElement);

this._counters = [];

@@ -522,7 +522,7 @@ Timeline.CountersGraph.CounterUI = class {

};

/**

- * @implements {UI.TimelineGrid.Calculator}

+ * @implements {PerfUI.TimelineGrid.Calculator}

* @unrestricted

Timeline.CounterGraphCalculator = class {