Fix building ASAN instrumented executables with custom entrypoints

Fix building ASAN instrumented executables with custom entrypoints

This is an alternative fix for
  https://codereview.chromium.org/2570153002/
As pointed by Nico, the previous patch may have issues with initializers.

BUG=636398
Review-Url: https://codereview.chromium.org/2621223003
Cr-Commit-Position: refs/heads/master@{#443926}
Committed: https://chromium.googlesource.com/chromium/src/+/7a284fcc9ea22e8b6f3717fee7267a21f55e8a02

[etienneb, 2017-01-11 20:47:12]

Description was changed from

==========
Fix building ASAN instrumented executable with custom entrypoints

This is an alternative fix for
  https://codereview.chromium.org/2570153002/

BUG=636398
==========

to

==========
Fix building ASAN instrumented executables with custom entrypoints

This is an alternative fix for
  https://codereview.chromium.org/2570153002/

BUG=636398
==========

[etienneb, 2017-01-13 16:05:08]

Description was changed from

==========
Fix building ASAN instrumented executables with custom entrypoints

This is an alternative fix for
  https://codereview.chromium.org/2570153002/

BUG=636398
==========

to

==========
Fix building ASAN instrumented executables with custom entrypoints

This is an alternative fix for
  https://codereview.chromium.org/2570153002/
As pointed by Nico, the previous patch may have issues with initializers.

BUG=636398
==========

[etienneb, 2017-01-13 16:05:08]

etienneb@chromium.org changed reviewers:
+ chrisha@chromium.org, grt@chromium.org, rnk@chromium.org, thakis@chromium.org

[etienneb, 2017-01-13 16:06:44]

PTAL.

[joedow, 2017-01-13 16:23:42]

joedow@chromium.org changed reviewers:
+ joedow@chromium.org

[joedow, 2017-01-13 16:23:43]

lgtm for remoting

[Reid Kleckner, 2017-01-13 16:27:23]

lgtm

I understand what Nico was saying about initializers now, so yeah, this seems
better. Past me missed that. >_<

[grt (UTC plus 2), 2017-01-16 15:41:17]

lgtm w/ nits

https://codereview.chromium.org/2621223003/diff/40001/remoting/host/win/BUILD.gn
File remoting/host/win/BUILD.gn (left):

https://codereview.chromium.org/2621223003/diff/40001/remoting/host/win/BUILD...
remoting/host/win/BUILD.gn:281: # "/NODEFAULTLIB",
maybe preserve a comment about this? was the original author headed somewhere
here?

https://codereview.chromium.org/2621223003/diff/40001/remoting/host/win/BUILD...
remoting/host/win/BUILD.gn:445: # "/NODEFAULTLIB",
same comment about comment

https://codereview.chromium.org/2621223003/diff/40001/remoting/host/win/entry...
File remoting/host/win/entry_point.cc (right):

https://codereview.chromium.org/2621223003/diff/40001/remoting/host/win/entry...
remoting/host/win/entry_point.cc:22: int WINAPI WinMain(HINSTANCE hInstance,
wWinMain here and wmain below -- i think this is built with /DUNICODE like
everything else.

[etienneb, 2017-01-16 16:58:37]

thanks grt@

https://codereview.chromium.org/2621223003/diff/40001/remoting/host/win/BUILD.gn
File remoting/host/win/BUILD.gn (left):

https://codereview.chromium.org/2621223003/diff/40001/remoting/host/win/BUILD...
remoting/host/win/BUILD.gn:281: # "/NODEFAULTLIB",
On 2017/01/16 15:41:17, grt (UTC plus 1) wrote:
> maybe preserve a comment about this? was the original author headed somewhere
> here?

Done.

https://codereview.chromium.org/2621223003/diff/40001/remoting/host/win/BUILD...
remoting/host/win/BUILD.gn:445: # "/NODEFAULTLIB",
On 2017/01/16 15:41:17, grt (UTC plus 1) wrote:
> same comment about comment

Done.

https://codereview.chromium.org/2621223003/diff/40001/remoting/host/win/entry...
File remoting/host/win/entry_point.cc (right):

https://codereview.chromium.org/2621223003/diff/40001/remoting/host/win/entry...
remoting/host/win/entry_point.cc:22: int WINAPI WinMain(HINSTANCE hInstance,
On 2017/01/16 15:41:17, grt (UTC plus 1) wrote:
> wWinMain here and wmain below -- i think this is built with /DUNICODE like
> everything else.

Done.

[etienneb, 2017-01-16 17:02:11]

The CQ bit was checked by etienneb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-16 17:02:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-16 17:55:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-16 17:55:10]

Dry run: This issue passed the CQ dry run.

[etienneb, 2017-01-16 18:37:51]

The CQ bit was checked by etienneb@chromium.org

[etienneb, 2017-01-16 18:37:52]

The patchset sent to the CQ was uploaded after l-g-t-m from rnk@chromium.org,
grt@chromium.org, joedow@chromium.org
Link to the patchset: https://codereview.chromium.org/2621223003/#ps80001
(title: "nits")

[commit-bot: I haz the power, 2017-01-16 18:38:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-16 18:42:41]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1484591871721730,
"parent_rev": "ce9a2515fc22794d7beb2268eaae525279a0c3b1", "commit_rev":
"7a284fcc9ea22e8b6f3717fee7267a21f55e8a02"}

[commit-bot: I haz the power, 2017-01-16 18:43:14]

Description was changed from

==========
Fix building ASAN instrumented executables with custom entrypoints

This is an alternative fix for
  https://codereview.chromium.org/2570153002/
As pointed by Nico, the previous patch may have issues with initializers.

BUG=636398
==========

to

==========
Fix building ASAN instrumented executables with custom entrypoints

This is an alternative fix for
  https://codereview.chromium.org/2570153002/
As pointed by Nico, the previous patch may have issues with initializers.

BUG=636398

Review-Url: https://codereview.chromium.org/2621223003
Cr-Commit-Position: refs/heads/master@{#443926}
Committed:
https://chromium.googlesource.com/chromium/src/+/7a284fcc9ea22e8b6f3717fee726...
==========

[commit-bot: I haz the power, 2017-01-16 18:43:16]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/7a284fcc9ea22e8b6f3717fee726...