chrome/installer/mini_installer/BUILD.gn - Issue 2621223003: Fix building ASAN instrumented executables with custom entrypoints

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/mini_installer/BUILD.gn

Issue 2621223003: Fix building ASAN instrumented executables with custom entrypoints (Closed)

Patch Set: nits Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/installer/mini_installer/BUILD.gn

diff --git a/chrome/installer/mini_installer/BUILD.gn b/chrome/installer/mini_installer/BUILD.gn

index 65df57ccac747c13e47e5c37d9bb33ca39b9723e..84be262612d00aedea5ef0e5c43261dab0ee2650 100644

--- a/chrome/installer/mini_installer/BUILD.gn

+++ b/chrome/installer/mini_installer/BUILD.gn

@@ -239,12 +239,15 @@ template("generate_mini_installer") {

]

ldflags = [

- "/ENTRY:MainEntryPoint",

"/FIXED:NO",

"/ignore:4199",

"/NXCOMPAT",

]

+ if (!is_asan) {

+ ldflags += [ "/ENTRY:MainEntryPoint" ]

+ }

libs = [ "setupapi.lib" ]

deps = [

« no previous file with comments | « base/win/BUILD.gn ('k') | chrome/installer/mini_installer/mini_installer.cc » ('j') | no next file with comments »