Fix building ASAN instrumented executables with custom entrypoints

remoting/host/win/BUILD.gn

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/toolchain/win/midl.gni")
 import("//build/win/message_compiler.gni")
 import("//media/media_options.gni")
 import("//remoting/build/config/remoting_build.gni")
 import("//remoting/host/installer/win/generate_clsids.gni")
 
@@ skipping 258 matching lines @@
     ":dpi_aware_exe_manifest",
     ":remoting_core",
     ":remoting_windows_resources",
   ]
 
   sources = [
     "$root_gen_dir/remoting/version.rc",
     "entry_point.cc",
   ]
 
-  ldflags = [
-    "/ENTRY:HostEntryPoint",
-    # "/NODEFAULTLIB",

[grt (UTC plus 2), 2017/01/16 15:41:17]

maybe preserve a comment about this? was the original author headed somewhere
here?

[etienneb, 2017/01/16 16:58:37]

Done.

-  ]
+  if (!is_asan) {
+    ldflags = [ "/ENTRY:HostEntryPoint" ]
+  }
 }
 
 executable("remoting_me2me_host") {
   configs += [
     "//build/config/compiler:wexit_time_destructors",
     "//build/config/win:windowed",
     "//remoting/build/config:remoting_me2me_host",
   ]
 
   defines = host_predefines + [ "REMOTING_HOST_BINARY=BINARY_HOST_ME2ME" ]
 
   deps = [
     ":dpi_aware_exe_manifest",
     ":remoting_core",
     ":remoting_windows_resources",
   ]
 
   sources = [
     "$root_gen_dir/remoting/version.rc",
     "entry_point.cc",
   ]
 
   output_name = "remoting_host"
 
-  ldflags = [ "/ENTRY:HostEntryPoint" ]
+  if (!is_asan) {
+    ldflags = [ "/ENTRY:HostEntryPoint" ]
+  }
 }
 
 shared_library("remoting_core") {
   configs += [ "//build/config/compiler:wexit_time_destructors" ]
 
   defines = host_predefines + [
               "_ATL_APARTMENT_THREADED",
               "_ATL_CSTRING_EXPLICIT_CONSTRUCTORS",
               "_ATL_NO_AUTOMATIC_NAMESPACE",
               "_ATL_NO_EXCEPTIONS",
@@ skipping 115 matching lines @@
     deps += [ ":dpi_aware_uiaccess_require_admin_exe_manifest" ]
   } else {
     deps += [ ":dpi_aware_exe_manifest" ]
   }
 
   sources = [
     "$root_gen_dir/remoting/version.rc",
     "entry_point.cc",
   ]
 
-  ldflags = [
-    "/ENTRY:HostEntryPoint",
-    # "/NODEFAULTLIB",

[grt (UTC plus 2), 2017/01/16 15:41:17]

same comment about comment

[etienneb, 2017/01/16 16:58:37]

Done.

-  ]
+  if (!is_asan) {
+    ldflags = [ "/ENTRY:HostEntryPoint" ]
+  }
 }
 
 executable("remoting_native_messaging_host") {
   configs += [ "//build/config/compiler:wexit_time_destructors" ]
 
   defines =
       host_predefines + [ "REMOTING_HOST_BINARY=BINARY_NATIVE_MESSAGING_HOST" ]
 
   deps = [
     ":remoting_core",
@@ skipping 25 matching lines @@
 
   output = "$root_gen_dir/remoting/{{source_name_part}}"
 
   locale_dir = webapp_locale_dir
 
   encoding = "utf-16"
 
   locales = remoting_locales
 }
 # TODO(GYP) More Windows remoting targets from remoting_host_win.gypi