Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1273)

Unified Diff: remoting/host/win/BUILD.gn

Issue 2621223003: Fix building ASAN instrumented executables with custom entrypoints (Closed)
Patch Set: nits Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/mini_installer/mini_installer.cc ('k') | remoting/host/win/entry_point.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/host/win/BUILD.gn
diff --git a/remoting/host/win/BUILD.gn b/remoting/host/win/BUILD.gn
index f6ddd335c88031124f7013d95a26fd75bf6cdfc8..80e3a380ffcc6c3ca9a9c4124fda709782bebdcc 100644
--- a/remoting/host/win/BUILD.gn
+++ b/remoting/host/win/BUILD.gn
@@ -276,10 +276,12 @@ executable("remoting_console") {
"entry_point.cc",
]
- ldflags = [
- "/ENTRY:HostEntryPoint",
- # "/NODEFAULTLIB",
- ]
+ if (!is_asan) {
+ ldflags = [
+ "/ENTRY:HostEntryPoint",
+ # "/NODEFAULTLIB",
+ ]
+ }
}
executable("remoting_me2me_host") {
@@ -304,7 +306,12 @@ executable("remoting_me2me_host") {
output_name = "remoting_host"
- ldflags = [ "/ENTRY:HostEntryPoint" ]
+ if (!is_asan) {
+ ldflags = [
+ "/ENTRY:HostEntryPoint",
+ # "/NODEFAULTLIB",
+ ]
+ }
}
shared_library("remoting_core") {
@@ -440,10 +447,12 @@ executable("remoting_desktop") {
"entry_point.cc",
]
- ldflags = [
- "/ENTRY:HostEntryPoint",
- # "/NODEFAULTLIB",
- ]
+ if (!is_asan) {
+ ldflags = [
+ "/ENTRY:HostEntryPoint",
+ # "/NODEFAULTLIB",
+ ]
+ }
}
executable("remoting_native_messaging_host") {
« no previous file with comments | « chrome/installer/mini_installer/mini_installer.cc ('k') | remoting/host/win/entry_point.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698