[tools/perf] Fix JavaScript interpolation in action_runner calls

[tools/perf] Fix JavaScript interpolation in action_runner calls

The API on action_runner to run JavaScript now supports safe and simple
interpolation of values into code templates. This CL fixes and cleans
up many of the callers which weren't using robust methods for quoting
such values.

BUG=catapult:#3028

Review-Url: https://codereview.chromium.org/2618333006
Cr-Commit-Position: refs/heads/master@{#443194}
Committed: https://chromium.googlesource.com/chromium/src/+/80aedca1fd5f6a735391ee96f7dbe24220d05782

[perezju, 2017-01-10 14:14:32]

The CQ bit was checked by perezju@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 14:14:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[perezju, 2017-01-10 14:20:12]

perezju@chromium.org changed reviewers:
+ hjd@chromium.org, nednguyen@google.com

[perezju, 2017-01-10 14:20:13]

I tried to be as careful as possible (not to fall again by something like
crbug.com/679518), but an extra pair of eyes would be useful to reduce chances
of breaking something.

[nednguyen, 2017-01-10 14:42:24]

lgtm

https://codereview.chromium.org/2618333006/diff/1/tools/perf/page_sets/google...
File tools/perf/page_sets/google_pages.py (right):

https://codereview.chromium.org/2618333006/diff/1/tools/perf/page_sets/google...
tools/perf/page_sets/google_pages.py:71: 'console.time("%s");' %
INTERACTION_NAME)
also change it here for consistency?

https://codereview.chromium.org/2618333006/diff/1/tools/perf/page_sets/todomv...
File tools/perf/page_sets/todomvc.py (right):

https://codereview.chromium.org/2618333006/diff/1/tools/perf/page_sets/todomv...
tools/perf/page_sets/todomvc.py:35: 'console.time("%s");' % INTERACTION_NAME)
also change here

[perezju, 2017-01-10 14:53:01]

https://codereview.chromium.org/2618333006/diff/1/tools/perf/page_sets/google...
File tools/perf/page_sets/google_pages.py (right):

https://codereview.chromium.org/2618333006/diff/1/tools/perf/page_sets/google...
tools/perf/page_sets/google_pages.py:71: 'console.time("%s");' %
INTERACTION_NAME)
On 2017/01/10 14:42:23, nednguyen wrote:
> also change it here for consistency?

Yup, thanks for pointing those out!

https://codereview.chromium.org/2618333006/diff/1/tools/perf/page_sets/todomv...
File tools/perf/page_sets/todomvc.py (right):

https://codereview.chromium.org/2618333006/diff/1/tools/perf/page_sets/todomv...
tools/perf/page_sets/todomvc.py:35: 'console.time("%s");' % INTERACTION_NAME)
On 2017/01/10 14:42:23, nednguyen wrote:
> also change here

Done.

[hjd, 2017-01-10 15:44:16]

lgtm

[perezju, 2017-01-10 15:52:46]

On 2017/01/10 15:44:16, hjd wrote:
> lgtm

Thanks for the reviews! I'll hold this a bit just to make sure that
https://codereview.chromium.org/2615943003 sticks and land this probably first
thing tomorrow morning.

[perezju, 2017-01-11 13:37:34]

The CQ bit was checked by perezju@chromium.org

[perezju, 2017-01-11 13:37:35]

The patchset sent to the CQ was uploaded after l-g-t-m from nednguyen@google.com
Link to the patchset: https://codereview.chromium.org/2618333006/#ps20001
(title: "fix a few more interpolations")

[commit-bot: I haz the power, 2017-01-11 13:37:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 15:16:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 15:16:27]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[perezju, 2017-01-11 15:30:47]

The CQ bit was checked by perezju@chromium.org

[commit-bot: I haz the power, 2017-01-11 15:31:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[perezju, 2017-01-11 15:31:33]

On 2017/01/11 15:16:27, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
>
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

Failure in android_n5x_swarming_rel appears to be a flake: crbug.com/679844
retrying ...

[commit-bot: I haz the power, 2017-01-11 16:49:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 16:49:32]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[perezju, 2017-01-12 09:27:12]

The CQ bit was checked by perezju@chromium.org

[commit-bot: I haz the power, 2017-01-12 09:27:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 10:03:06]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484213232852990,
"parent_rev": "7bc84c961b4495910c6b92a763e59467b4e4b1a7", "commit_rev":
"80aedca1fd5f6a735391ee96f7dbe24220d05782"}

[commit-bot: I haz the power, 2017-01-12 10:03:49]

Description was changed from

==========
[tools/perf] Fix JavaScript interpolation in action_runner calls

The API on action_runner to run JavaScript now supports safe and simple
interpolation of values into code templates. This CL fixes and cleans
up many of the callers which weren't using robust methods for quoting
such values.

BUG=catapult:#3028
==========

to

==========
[tools/perf] Fix JavaScript interpolation in action_runner calls

The API on action_runner to run JavaScript now supports safe and simple
interpolation of values into code templates. This CL fixes and cleans
up many of the callers which weren't using robust methods for quoting
such values.

BUG=catapult:#3028

Review-Url: https://codereview.chromium.org/2618333006
Cr-Commit-Position: refs/heads/master@{#443194}
Committed:
https://chromium.googlesource.com/chromium/src/+/80aedca1fd5f6a735391ee96f7db...
==========

[commit-bot: I haz the power, 2017-01-12 10:03:50]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/80aedca1fd5f6a735391ee96f7db...