tools/perf/page_sets/top_7_stress.py - Issue 2618333006: [tools/perf] Fix JavaScript interpolation in action_runner calls

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/page_sets/top_7_stress.py

Issue 2618333006: [tools/perf] Fix JavaScript interpolation in action_runner calls (Closed)

Patch Set: fix a few more interpolations Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/page_sets/top_7_stress.py

diff --git a/tools/perf/page_sets/top_7_stress.py b/tools/perf/page_sets/top_7_stress.py

index ee228d95b20ee9bc2d71e59f7376685c73bc0db3..c46eb79212c4e5cb22dc28b02d16a71686f7547c 100644

--- a/tools/perf/page_sets/top_7_stress.py

+++ b/tools/perf/page_sets/top_7_stress.py

@@ -11,9 +11,8 @@ def _GetCurrentLocation(action_runner):

def _WaitForLocationChange(action_runner, old_href):

- # TODO(catapult:#3028): Fix interpolation of JavaScript values.

action_runner.WaitForJavaScriptCondition(

- 'document.location.href != "%s"' % old_href)

+ 'document.location.href != {{ old_href }}', old_href=old_href)

class Top7StressPage(page_module.Page):

« no previous file with comments | « tools/perf/page_sets/todomvc.py ('k') | no next file » | no next file with comments »