[Telemetry] Allow value interpolation in action_runner JavaScript API

[Telemetry] Allow value interpolation in action_runner JavaScript API

The new interface allows clients to easily interpolate values within
JavaScript template snippents. For example:

  runner.ExecuteJavaScript('var foo = {{ value }};', value=1);

Also update clients within catapult to use the new interface.

API change: timeout_in_seconds argument in WaitForJavaScriptCondition
can no longer be accessed as a positional argument, the keyword must
be used explicitly to set that argument.

Corresponding chromium CL: https://codereview.chromium.org/2617483006/

BUG=catapult:#3028

Review-Url: https://codereview.chromium.org/2615943003
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/9c4a543d55a4afcab403f792785fae964586978c

[perezju, 2017-01-06 16:14:24]

Description was changed from

==========
[Telemetry] Allow value interpolation in action_runner JavaScript API

The new interface allows clients to easily interpolate values within
JavaScript template snippents. For example:

  runner.ExecuteJavaScript('var foo = {{ value }};', value=1);

API change: timeout_in_seconds argument in WaitForJavaScriptCondition
can no longer be accessed as a positional argument, the keyword must
be used explicitly to set that argument.

Corresponding chromium CL: https://codereview.chromium.org/2617483006/

BUG=catapult:#3028
==========

to

==========
[Telemetry] Allow value interpolation in action_runner JavaScript API

The new interface allows clients to easily interpolate values within
JavaScript template snippents. For example:

  runner.ExecuteJavaScript('var foo = {{ value }};', value=1);

Also update clients within catapult to use the new interface.

API change: timeout_in_seconds argument in WaitForJavaScriptCondition
can no longer be accessed as a positional argument, the keyword must
be used explicitly to set that argument.

Corresponding chromium CL: https://codereview.chromium.org/2617483006/

BUG=catapult:#3028
==========

[perezju, 2017-01-06 16:17:14]

The CQ bit was checked by perezju@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 16:17:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[perezju, 2017-01-06 16:18:21]

perezju@chromium.org changed reviewers:
+ nednguyen@google.com

[nednguyen, 2017-01-06 16:23:56]

lgtm

[commit-bot: I haz the power, 2017-01-06 16:29:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 16:29:12]

Dry run: Try jobs failed on following builders:
  Catapult Mac Tryserver on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Ma...)

[perezju, 2017-01-09 11:53:00]

This should fix some of the errors, but probably a few remain. Re-running git cl
try now ...

https://codereview.chromium.org/2615943003/diff/20001/telemetry/telemetry/int...
File telemetry/telemetry/internal/actions/action_runner.py (right):

https://codereview.chromium.org/2615943003/diff/20001/telemetry/telemetry/int...
telemetry/telemetry/internal/actions/action_runner.py:90: return
Interaction(self, label, flags)
The Interaction constructor expects an action_runner, but this used to
mistakenly send a tab instead. It sort of worked by accident anyway, because
then we only call ExecuteJavaScript on the object, which is supported by both.

[perezju, 2017-01-09 11:53:08]

The CQ bit was checked by perezju@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-09 11:53:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-09 12:04:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-09 12:04:02]

Dry run: Try jobs failed on following builders:
  Catapult Mac Tryserver on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Ma...)

[perezju, 2017-01-09 13:13:20]

More tests fixed ... git cl try-ing ...

https://codereview.chromium.org/2615943003/diff/40001/telemetry/telemetry/int...
File
telemetry/telemetry/internal/backends/form_based_credentials_backend_unittest_base.py
(right):

https://codereview.chromium.org/2615943003/diff/40001/telemetry/telemetry/int...
telemetry/telemetry/internal/backends/form_based_credentials_backend_unittest_base.py:35:
'(document.querySelector({{ form_id }}) !== null) || ({{ @code }})')
This wasn't a great test to begin with. Looks very much like a "change detection
test" [1]. Ideally should be replaced with a test not using a mock, but this
whole FormBasedCredentials thing seems to be scheduled for deprecation anyway so
I just changed the test enough to make it pass.

[1]:
https://testing.googleblog.com/2015/01/testing-on-toilet-change-detector-test...

[perezju, 2017-01-09 13:13:31]

The CQ bit was checked by perezju@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-09 13:13:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-09 13:33:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-09 13:33:04]

Dry run: This issue passed the CQ dry run.

[nednguyen, 2017-01-09 14:06:51]

On 2017/01/09 13:13:20, perezju wrote:
> More tests fixed ... git cl try-ing ...
> 
>
https://codereview.chromium.org/2615943003/diff/40001/telemetry/telemetry/int...
> File
>
telemetry/telemetry/internal/backends/form_based_credentials_backend_unittest_base.py
> (right):
> 
>
https://codereview.chromium.org/2615943003/diff/40001/telemetry/telemetry/int...
>
telemetry/telemetry/internal/backends/form_based_credentials_backend_unittest_base.py:35:
> '(document.querySelector({{ form_id }}) !== null) || ({{ @code }})')
> This wasn't a great test to begin with. Looks very much like a "change
detection
> test" [1]. Ideally should be replaced with a test not using a mock, but this
> whole FormBasedCredentials thing seems to be scheduled for deprecation anyway
so
> I just changed the test enough to make it pass.
> 
> [1]:
>
https://testing.googleblog.com/2015/01/testing-on-toilet-change-detector-test...

Feel free to delete tests in form_based_credentials_backend_unittest_base.py,
the whole form_based_credentials_backend should be removed as people converting
to use login_hepler

[nednguyen, 2017-01-09 14:08:01]

lgtm

[perezju, 2017-01-09 14:10:45]

On 2017/01/09 14:08:01, nednguyen wrote:
> lgtm

All tests green. Landing now.

[perezju, 2017-01-09 14:10:50]

The CQ bit was checked by perezju@chromium.org

[commit-bot: I haz the power, 2017-01-09 14:10:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-09 14:12:32]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1483971050514840,
"parent_rev": "487c2d0050eb9d13f8438ac9a701acc4d3f30d56", "commit_rev":
"9c4a543d55a4afcab403f792785fae964586978c"}

[commit-bot: I haz the power, 2017-01-09 14:12:35]

Description was changed from

==========
[Telemetry] Allow value interpolation in action_runner JavaScript API

The new interface allows clients to easily interpolate values within
JavaScript template snippents. For example:

  runner.ExecuteJavaScript('var foo = {{ value }};', value=1);

Also update clients within catapult to use the new interface.

API change: timeout_in_seconds argument in WaitForJavaScriptCondition
can no longer be accessed as a positional argument, the keyword must
be used explicitly to set that argument.

Corresponding chromium CL: https://codereview.chromium.org/2617483006/

BUG=catapult:#3028
==========

to

==========
[Telemetry] Allow value interpolation in action_runner JavaScript API

The new interface allows clients to easily interpolate values within
JavaScript template snippents. For example:

  runner.ExecuteJavaScript('var foo = {{ value }};', value=1);

Also update clients within catapult to use the new interface.

API change: timeout_in_seconds argument in WaitForJavaScriptCondition
can no longer be accessed as a positional argument, the keyword must
be used explicitly to set that argument.

Corresponding chromium CL: https://codereview.chromium.org/2617483006/

BUG=catapult:#3028

Review-Url: https://codereview.chromium.org/2615943003
Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2017-01-09 14:12:36]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...