tools/perf/page_sets/login_helpers/login_utils.py - Issue 2618333006: [tools/perf] Fix JavaScript interpolation in action_runner calls

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/page_sets/login_helpers/login_utils.py

Issue 2618333006: [tools/perf] Fix JavaScript interpolation in action_runner calls (Closed)

Patch Set: fix a few more interpolations Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/page_sets/login_helpers/login_utils.py

diff --git a/tools/perf/page_sets/login_helpers/login_utils.py b/tools/perf/page_sets/login_helpers/login_utils.py

index 296ed20f140345f4ec9be55d3f343f1889a4f115..710c415a659dbf53c91ff6149a8887b4d7cfb4fe 100644

--- a/tools/perf/page_sets/login_helpers/login_utils.py

+++ b/tools/perf/page_sets/login_helpers/login_utils.py

@@ -45,10 +45,9 @@ def InputWithSelector(action_runner, input_text, input_selector):

possible exceptions.

"""

action_runner.WaitForElement(selector=input_selector)

- # TODO(catapult:#3028): Fix interpolation of JavaScript values.

action_runner.ExecuteJavaScript(

- 'document.querySelector("%s").value = "%s";' %

- (input_selector, input_text))

+ 'document.querySelector({{ selector }}).value = {{ value }};',

+ selector=input_selector, value=input_text)

def InputForm(action_runner, input_text, input_id, form_id=None):

"""Sets the text value of an input field in a form on the page.

« no previous file with comments | « tools/perf/page_sets/login_helpers/google_login.py ('k') | tools/perf/page_sets/polymer.py » ('j') | no next file with comments »