Make CSSInterpolationType::maybeConvertSingle() final

Make CSSInterpolationType::maybeConvertSingle() final

This change removes the ability for subclasses of CSSInterpolationType
to override the behaviour of maybeConvertSingle().
A virtual additiveKeyframeHook() function has been added to support the
previous use case for overriding maybeConvertSingle() of recording
whether a value is additive or not in the NonInterpolableValue.

Making CSSInterpolationType::maybeConvertSingle() final is part of
supporting smooth interpolation on registered custom properties. This
method will change in the near future and it will no longer be
appropriate for subclasses to override its behaviour.

This patch introduces no changes in behaviour.

BUG=671904
Review-Url: https://codereview.chromium.org/2617453003
Cr-Commit-Position: refs/heads/master@{#442190}
Committed: https://chromium.googlesource.com/chromium/src/+/e2a6bbc950788ffc44fa8cddf6d93a284a0fcf01

[alancutter (OOO until 2018), 2017-01-04 06:33:15]

Description was changed from

==========
additiveKeyframeHook

BUG=
==========

to

==========
Make CSSInterpolationType::maybeConvertSingle() final

This change removes the ability for subclasses of CSSInterpolationType
to override the behaviour of maybeConvertSingle().
A virtual additiveKeyframeHook() function has been added to support the
previous use case for overriding maybeConvertSingle(); to record whether
a value is additive or not in the NonInterpolableValue.

Making CSSInterpolationType::maybeConvertSingle() final is part of
supporting smooth interpolation on registered custom properties. This
method will change in the near future and it will no longer be
appropriate for subclasses to override its behaviour.

This patch introduces no changes in behaviour.

BUG=671904
==========

[alancutter (OOO until 2018), 2017-01-05 04:46:40]

Description was changed from

==========
Make CSSInterpolationType::maybeConvertSingle() final

This change removes the ability for subclasses of CSSInterpolationType
to override the behaviour of maybeConvertSingle().
A virtual additiveKeyframeHook() function has been added to support the
previous use case for overriding maybeConvertSingle(); to record whether
a value is additive or not in the NonInterpolableValue.

Making CSSInterpolationType::maybeConvertSingle() final is part of
supporting smooth interpolation on registered custom properties. This
method will change in the near future and it will no longer be
appropriate for subclasses to override its behaviour.

This patch introduces no changes in behaviour.

BUG=671904
==========

to

==========
Make CSSInterpolationType::maybeConvertSingle() final

This change removes the ability for subclasses of CSSInterpolationType
to override the behaviour of maybeConvertSingle().
A virtual additiveKeyframeHook() function has been added to support the
previous use case for overriding maybeConvertSingle() of recording
whether a value is additive or not in the NonInterpolableValue.

Making CSSInterpolationType::maybeConvertSingle() final is part of
supporting smooth interpolation on registered custom properties. This
method will change in the near future and it will no longer be
appropriate for subclasses to override its behaviour.

This patch introduces no changes in behaviour.

BUG=671904
==========

[alancutter (OOO until 2018), 2017-01-05 04:46:50]

alancutter@chromium.org changed reviewers:
+ ericwilligers@chromium.org

[Eric Willigers, 2017-01-05 05:39:46]

The CQ bit was checked by ericwilligers@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-05 05:40:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 07:56:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 07:56:36]

Dry run: This issue passed the CQ dry run.

[Eric Willigers, 2017-01-06 03:13:55]

The CQ bit was checked by ericwilligers@chromium.org

[Eric Willigers, 2017-01-06 03:13:56]

lgtm

[commit-bot: I haz the power, 2017-01-06 03:14:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 03:14:14]

This CL has an open dependency (Issue 2614613002 Patch 1). Please resolve the
dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[alancutter (OOO until 2018), 2017-01-09 00:42:48]

The CQ bit was checked by alancutter@chromium.org

[commit-bot: I haz the power, 2017-01-09 00:42:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-09 02:55:01]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1483922568771940,
"parent_rev": "1352c4d7f1deb4196f3498cc76462c45cf325622", "commit_rev":
"e2a6bbc950788ffc44fa8cddf6d93a284a0fcf01"}

[commit-bot: I haz the power, 2017-01-09 02:55:28]

Description was changed from

==========
Make CSSInterpolationType::maybeConvertSingle() final

This change removes the ability for subclasses of CSSInterpolationType
to override the behaviour of maybeConvertSingle().
A virtual additiveKeyframeHook() function has been added to support the
previous use case for overriding maybeConvertSingle() of recording
whether a value is additive or not in the NonInterpolableValue.

Making CSSInterpolationType::maybeConvertSingle() final is part of
supporting smooth interpolation on registered custom properties. This
method will change in the near future and it will no longer be
appropriate for subclasses to override its behaviour.

This patch introduces no changes in behaviour.

BUG=671904
==========

to

==========
Make CSSInterpolationType::maybeConvertSingle() final

This change removes the ability for subclasses of CSSInterpolationType
to override the behaviour of maybeConvertSingle().
A virtual additiveKeyframeHook() function has been added to support the
previous use case for overriding maybeConvertSingle() of recording
whether a value is additive or not in the NonInterpolableValue.

Making CSSInterpolationType::maybeConvertSingle() final is part of
supporting smooth interpolation on registered custom properties. This
method will change in the near future and it will no longer be
appropriate for subclasses to override its behaviour.

This patch introduces no changes in behaviour.

BUG=671904

Review-Url: https://codereview.chromium.org/2617453003
Cr-Commit-Position: refs/heads/master@{#442190}
Committed:
https://chromium.googlesource.com/chromium/src/+/e2a6bbc950788ffc44fa8cddf6d9...
==========

[commit-bot: I haz the power, 2017-01-09 02:55:30]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e2a6bbc950788ffc44fa8cddf6d9...