Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Unified Diff: third_party/WebKit/Source/core/animation/CSSRotateInterpolationType.cpp

Issue 2617453003: Make CSSInterpolationType::maybeConvertSingle() final (Closed)
Patch Set: No lambdas Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/animation/CSSRotateInterpolationType.cpp
diff --git a/third_party/WebKit/Source/core/animation/CSSRotateInterpolationType.cpp b/third_party/WebKit/Source/core/animation/CSSRotateInterpolationType.cpp
index 7753731ef05eacdb9e26303452f841783c392395..79095cd4b075eff47396d0b236b6312066d963fe 100644
--- a/third_party/WebKit/Source/core/animation/CSSRotateInterpolationType.cpp
+++ b/third_party/WebKit/Source/core/animation/CSSRotateInterpolationType.cpp
@@ -161,19 +161,10 @@ InterpolationValue CSSRotateInterpolationType::maybeConvertValue(
return convertRotation(StyleBuilderConverter::convertRotation(value));
}
-InterpolationValue CSSRotateInterpolationType::maybeConvertSingle(
- const PropertySpecificKeyframe& keyframe,
- const InterpolationEnvironment& environment,
- const InterpolationValue& underlying,
- ConversionCheckers& conversionCheckers) const {
- InterpolationValue result = CSSInterpolationType::maybeConvertSingle(
- keyframe, environment, underlying, conversionCheckers);
- if (!result)
- return nullptr;
- if (keyframe.composite() != EffectModel::CompositeReplace)
- toCSSRotateNonInterpolableValue(*result.nonInterpolableValue)
- .setSingleAdditive();
- return result;
+void CSSRotateInterpolationType::additiveKeyframeHook(
+ InterpolationValue& value) const {
+ toCSSRotateNonInterpolableValue(*value.nonInterpolableValue)
+ .setSingleAdditive();
}
PairwiseInterpolationValue CSSRotateInterpolationType::maybeMergeSingles(

Powered by Google App Engine
This is Rietveld 408576698