Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 2618673003: Store registered property InterpolationTypes in PropertyRegistration (Closed)

Created:
3 years, 11 months ago by alancutter (OOO until 2018)
Modified:
3 years, 11 months ago
Reviewers:
Timothy Loh
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, Eric Willigers, rjwright, rwlbuis, shans, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Store registered property InterpolationTypes in PropertyRegistration This change moves the storage of InterpolationTypes for a registered custom property to its PropertyRegistration object. This is in preparation for supporting smooth interpolations on registered custom properties. There are no behavioural changes made by this patch. BUG=671904 Review-Url: https://codereview.chromium.org/2618673003 Cr-Commit-Position: refs/heads/master@{#442204} Committed: https://chromium.googlesource.com/chromium/src/+/3e5152f0ec19bdbc37aa171be11690f86a6ab311

Patch Set 1 #

Total comments: 4

Patch Set 2 : Rebased #

Patch Set 3 : Remove duplicate #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -16 lines) Patch
M third_party/WebKit/Source/core/animation/CSSInterpolationTypesMap.cpp View 3 chunks +31 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/animation/InterpolationType.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/PropertyRegistration.cpp View 1 5 chunks +20 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/css/PropertyRegistry.h View 4 chunks +12 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/PropertyRegistry.cpp View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
alancutter (OOO until 2018)
3 years, 11 months ago (2017-01-05 04:46:11 UTC) #3
Timothy Loh
lgtm but I'm not really familiar with interpolation stuff. https://codereview.chromium.org/2618673003/diff/1/third_party/WebKit/Source/core/css/PropertyRegistration.cpp File third_party/WebKit/Source/core/css/PropertyRegistration.cpp (right): https://codereview.chromium.org/2618673003/diff/1/third_party/WebKit/Source/core/css/PropertyRegistration.cpp#newcode7 third_party/WebKit/Source/core/css/PropertyRegistration.cpp:7: ...
3 years, 11 months ago (2017-01-09 05:07:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2618673003/20001
3 years, 11 months ago (2017-01-09 05:32:24 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/298925) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 11 months ago (2017-01-09 05:42:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2618673003/40001
3 years, 11 months ago (2017-01-09 05:45:27 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/3e5152f0ec19bdbc37aa171be11690f86a6ab311
3 years, 11 months ago (2017-01-09 07:14:59 UTC) #15
alancutter (OOO until 2018)
3 years, 11 months ago (2017-01-16 00:23:52 UTC) #16
Message was sent while issue was closed.
Belated replies that I forgot to send out. ):

https://codereview.chromium.org/2618673003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/PropertyRegistration.cpp (right):

https://codereview.chromium.org/2618673003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/PropertyRegistration.cpp:7: #include
"core/animation/CSSColorInterpolationType.h"
On 2017/01/09 at 05:07:23, Timothy Loh wrote:
> not used yet

Removed

https://codereview.chromium.org/2618673003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/Document.h (right):

https://codereview.chromium.org/2618673003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/Document.h:1299: const PropertyRegistry*
propertyRegistry() const;
On 2017/01/09 at 05:07:23, Timothy Loh wrote:
> needs a rebase, this exists now :O

Rebased.

Powered by Google App Engine
This is Rietveld 408576698