Remove maybeConvertSingle override in CSSValueInterpolationType

Remove maybeConvertSingle override in CSSValueInterpolationType

This change refactors CSSValueInterpolationType to not override
CSSInterpolationType::maybeConvertSingle() and instead
use the more specific conversion functions as is the norm.

This change is part of supporting smooth interpolation of
registered custom properties. More complex behaviour will be
added to CSSInterpolationType::maybeConvertSingle() which must
be shared with the CSSValueInterpolationType subclass.

There are no changes in behaviour made by this patch.

BUG=671904
Review-Url: https://codereview.chromium.org/2614613002
Cr-Commit-Position: refs/heads/master@{#441885}
Committed: https://chromium.googlesource.com/chromium/src/+/41d8555158262926a0971b6f40da9988f80e6c55

[alancutter (OOO until 2018), 2017-01-04 05:48:53]

Description was changed from

==========
Remove maybeConvertSingle override in CSSValueInterpolationType

This change refactors CSSValueInterpolationType to not override
CSSInterpolationType::maybeConvertSingle() and instead
use the more specific conversion functions as is the norm.

There are no changes in behaviour made by this patch.

BUG=671904
==========

to

==========
Remove maybeConvertSingle override in CSSValueInterpolationType

This change refactors CSSValueInterpolationType to not override
CSSInterpolationType::maybeConvertSingle() and instead
use the more specific conversion functions as is the norm.

This change is part of supporting smooth interpolation of
registered custom properties. More complex behaviour will be
added to CSSInterpolationType::maybeConvertSingle() which must
be shared with the CSSValueInterpolationType subclass.

There are no changes in behaviour made by this patch.

BUG=671904
==========

[alancutter (OOO until 2018), 2017-01-06 00:51:04]

alancutter@chromium.org changed reviewers:
+ suzyh@chromium.org

[suzyh_UTC10 (ex-contributor), 2017-01-06 03:23:03]

https://codereview.chromium.org/2614613002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/animation/CSSValueInterpolationType.cpp
(right):

https://codereview.chromium.org/2614613002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/animation/CSSValueInterpolationType.cpp:40:
InterpolationValue CSSValueInterpolationType::maybeConvertInitial(
The initial and inherit code paths do not exist in the original
maybeConvertSingle. Do these values ever occur for CSSValueInterpolationType?

https://codereview.chromium.org/2614613002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/animation/CSSValueInterpolationType.h
(right):

https://codereview.chromium.org/2614613002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/animation/CSSValueInterpolationType.h:35: return
nullptr;
Consider adding a brief note as to why this always returns nullptr. I assume
it's an extension of "Never supports pairwise conversion" - "Never supports
additive animation" or similar?

[alancutter (OOO until 2018), 2017-01-06 04:16:23]

https://codereview.chromium.org/2614613002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/animation/CSSValueInterpolationType.cpp
(right):

https://codereview.chromium.org/2614613002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/animation/CSSValueInterpolationType.cpp:40:
InterpolationValue CSSValueInterpolationType::maybeConvertInitial(
On 2017/01/06 at 03:23:03, suzyh wrote:
> The initial and inherit code paths do not exist in the original
maybeConvertSingle. Do these values ever occur for CSSValueInterpolationType?

The previous maybeConvertSingle() override was indiscriminate about initial and
inherit. These new overrides are performing an equivalent behaviour as before.

https://codereview.chromium.org/2614613002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/animation/CSSValueInterpolationType.h
(right):

https://codereview.chromium.org/2614613002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/animation/CSSValueInterpolationType.h:35: return
nullptr;
On 2017/01/06 at 03:23:03, suzyh wrote:
> Consider adding a brief note as to why this always returns nullptr. I assume
it's an extension of "Never supports pairwise conversion" - "Never supports
additive animation" or similar?

Added comment explaining why nullptr.

[suzyh_UTC10 (ex-contributor), 2017-01-06 04:22:24]

lgtm

[alancutter (OOO until 2018), 2017-01-06 04:33:58]

The CQ bit was checked by alancutter@chromium.org

[commit-bot: I haz the power, 2017-01-06 04:34:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 06:11:57]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1483677238239040,
"parent_rev": "a4ecd5b7dee7b4ea7444dee445f9757a34d43564", "commit_rev":
"41d8555158262926a0971b6f40da9988f80e6c55"}

[commit-bot: I haz the power, 2017-01-06 06:12:24]

Description was changed from

==========
Remove maybeConvertSingle override in CSSValueInterpolationType

This change refactors CSSValueInterpolationType to not override
CSSInterpolationType::maybeConvertSingle() and instead
use the more specific conversion functions as is the norm.

This change is part of supporting smooth interpolation of
registered custom properties. More complex behaviour will be
added to CSSInterpolationType::maybeConvertSingle() which must
be shared with the CSSValueInterpolationType subclass.

There are no changes in behaviour made by this patch.

BUG=671904
==========

to

==========
Remove maybeConvertSingle override in CSSValueInterpolationType

This change refactors CSSValueInterpolationType to not override
CSSInterpolationType::maybeConvertSingle() and instead
use the more specific conversion functions as is the norm.

This change is part of supporting smooth interpolation of
registered custom properties. More complex behaviour will be
added to CSSInterpolationType::maybeConvertSingle() which must
be shared with the CSSValueInterpolationType subclass.

There are no changes in behaviour made by this patch.

BUG=671904

Review-Url: https://codereview.chromium.org/2614613002
Cr-Commit-Position: refs/heads/master@{#441885}
Committed:
https://chromium.googlesource.com/chromium/src/+/41d8555158262926a0971b6f40da...
==========

[commit-bot: I haz the power, 2017-01-06 06:12:25]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/41d8555158262926a0971b6f40da...