[Devtools] Removed getters/setters for NetworkRequest requestId

[Devtools] Removed getters/setters for NetworkRequest requestId

R=caseq
BUG=679105
Review-Url: https://codereview.chromium.org/2617283003
Cr-Commit-Position: refs/heads/master@{#442521}
Committed: https://chromium.googlesource.com/chromium/src/+/b7b01ac5e2085ad23f1a01b84b2ce27daced0f70

[allada, 2017-01-07 00:55:26]

allada@chromium.org changed reviewers:
+ dgozman@chromium.org, luoe@chromium.org

[allada, 2017-01-07 00:55:26]

PTL

https://codereview.chromium.org/2617283003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js (right):

https://codereview.chromium.org/2617283003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js:171: /**
@type {!Object<string, !SDK.NetworkRequest>} */
Closure did not catch stuff in this file, so I fixed this and it and closure
found more bugs which I also fixed in this patch.

[allada, 2017-01-07 01:04:14]

Description was changed from

==========
[Devtools] Removed getters/setters for NetworkRequest requestId

R=caseq
BUG=None
==========

to

==========
[Devtools] Removed getters/setters for NetworkRequest requestId

R=caseq
BUG=679105
==========

[allada, 2017-01-07 01:04:27]

The CQ bit was checked by allada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-07 01:05:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-07 02:25:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-07 02:25:46]

Dry run: This issue passed the CQ dry run.

[luoe, 2017-01-09 20:23:01]

lgtm with comments

https://codereview.chromium.org/2617283003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/NetworkLog.js (right):

https://codereview.chromium.org/2617283003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/NetworkLog.js:129:
this._requestForId[request.requestId] = request;
Should this use the getter "this._requestForId[request.requestId()]"?

https://codereview.chromium.org/2617283003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js (right):

https://codereview.chromium.org/2617283003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js:171: /**
@type {!Object<string, !SDK.NetworkRequest>} */
Why not "@type {!Object<!Protocol.Network.RequestId, !SDK.NetworkRequest>}" ?

https://codereview.chromium.org/2617283003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js (right):

https://codereview.chromium.org/2617283003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js:1177:
this.target().networkAgent().replayXHR(this.requestId());
this.target().networkAgent().replayXHR(this._requestId);
so that it matches line 1039 in _innerRequestContent

[dgozman, 2017-01-09 21:43:34]

lgtm

https://codereview.chromium.org/2617283003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/NetworkLog.js (right):

https://codereview.chromium.org/2617283003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/NetworkLog.js:129:
this._requestForId[request.requestId] = request;
On 2017/01/09 20:23:00, luoe wrote:
> Should this use the getter "this._requestForId[request.requestId()]"?

+1

[allada, 2017-01-09 23:14:06]

done.

[allada, 2017-01-10 00:12:11]

The CQ bit was checked by allada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 00:13:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[allada, 2017-01-10 00:38:10]

The CQ bit was checked by allada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 00:39:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 04:12:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 04:12:30]

Dry run: This issue passed the CQ dry run.

[allada, 2017-01-10 06:55:30]

The CQ bit was checked by allada@chromium.org

[allada, 2017-01-10 06:55:31]

The patchset sent to the CQ was uploaded after l-g-t-m from
dgozman@chromium.org, luoe@chromium.org
Link to the patchset: https://codereview.chromium.org/2617283003/#ps100001
(title: "Merge branch 'TYPE_OBJECT_JS' into REMOVE_GETTERS_SETTERS_1")

[commit-bot: I haz the power, 2017-01-10 06:55:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 07:00:04]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1484031330807730,
"parent_rev": "5347b46f28ff183a55d8858b5a604aeee45d984c", "commit_rev":
"b7b01ac5e2085ad23f1a01b84b2ce27daced0f70"}

[commit-bot: I haz the power, 2017-01-10 07:00:33]

Description was changed from

==========
[Devtools] Removed getters/setters for NetworkRequest requestId

R=caseq
BUG=679105
==========

to

==========
[Devtools] Removed getters/setters for NetworkRequest requestId

R=caseq
BUG=679105

Review-Url: https://codereview.chromium.org/2617283003
Cr-Commit-Position: refs/heads/master@{#442521}
Committed:
https://chromium.googlesource.com/chromium/src/+/b7b01ac5e2085ad23f1a01b84b2c...
==========

[commit-bot: I haz the power, 2017-01-10 07:00:34]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/b7b01ac5e2085ad23f1a01b84b2c...