third_party/WebKit/LayoutTests/inspector/network/network-update-calculator-for-all-requests.html - Issue 2617283003: [Devtools] Removed getters/setters for NetworkRequest requestId

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector/network/network-update-calculator-for-all-requests.html

Issue 2617283003: [Devtools] Removed getters/setters for NetworkRequest requestId (Closed)

Patch Set: Merge branch 'TYPE_OBJECT_JS' into REMOVE_GETTERS_SETTERS_1 Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/network/network-filter-updated-requests.html ('k') | third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector/network/network-update-calculator-for-all-requests.html

diff --git a/third_party/WebKit/LayoutTests/inspector/network/network-update-calculator-for-all-requests.html b/third_party/WebKit/LayoutTests/inspector/network/network-update-calculator-for-all-requests.html

index 4e5b29685e8f71a8ab79e5ed172c693a7dd50bd5..95163abc090b8402cbbfcd45d8e8baf6945d9a71 100644

--- a/third_party/WebKit/LayoutTests/inspector/network/network-update-calculator-for-all-requests.html

+++ b/third_party/WebKit/LayoutTests/inspector/network/network-update-calculator-for-all-requests.html

@@ -13,15 +13,15 @@ function test() {

{

var request = new SDK.NetworkRequest(SDK.targetManager.mainTarget(), "", "", "", "", "");

request.setResourceType(type);

- request.requestId = id;

+ request.setRequestId(id);

request.setIssueTime(startTime);

request.endTime = endTime;

target._appendRequest(request);

target._refresh();

- var isFilteredOut = !!target._nodesByRequestId.get(request.requestId)[Network.NetworkLogView._isFilteredOutSymbol];

+ var isFilteredOut = !!target._nodesByRequestId.get(request.requestId())[Network.NetworkLogView._isFilteredOutSymbol];

InspectorTest.addResult("");

- InspectorTest.addResult("Appended request [" + request.requestId + "] of type '" + request.resourceType().name() + "' is hidden: " + isFilteredOut + " from [" + request.startTime + "] to [" + request.endTime + "]");

+ InspectorTest.addResult("Appended request [" + request.requestId() + "] of type '" + request.resourceType().name() + "' is hidden: " + isFilteredOut + " from [" + request.startTime + "] to [" + request.endTime + "]");

InspectorTest.addResult("Timeline: from [" + target._calculator.minimumBoundary() + "] to [" + target._calculator.maximumBoundary() + "]");

}