Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(735)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

Issue 2617283003: [Devtools] Removed getters/setters for NetworkRequest requestId (Closed)
Patch Set: Merge branch 'TYPE_OBJECT_JS' into REMOVE_GETTERS_SETTERS_1 Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
index bff7d1641d83bc72a1b777679da7abdea7a808dd..49af60598250bedde6a19356dcf35f020c1bca46 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
@@ -349,7 +349,7 @@ Network.NetworkLogView = class extends UI.VBox {
* @return {?Network.NetworkNode}
*/
nodeForRequest(request) {
- return this._nodesByRequestId.get(request.requestId);
+ return this._nodesByRequestId.get(request.requestId());
}
/**
@@ -909,10 +909,10 @@ Network.NetworkLogView = class extends UI.VBox {
// In case of redirect request id is reassigned to a redirected
// request and we need to update _nodesByRequestId and search results.
- var originalRequestNode = this._nodesByRequestId.get(request.requestId);
+ var originalRequestNode = this._nodesByRequestId.get(request.requestId());
if (originalRequestNode)
- this._nodesByRequestId.set(originalRequestNode.request().requestId, originalRequestNode);
- this._nodesByRequestId.set(request.requestId, node);
+ this._nodesByRequestId.set(originalRequestNode.request().requestId(), originalRequestNode);
+ this._nodesByRequestId.set(request.requestId(), node);
// Pull all the redirects of the main request upon commit load.
if (request.redirects) {
@@ -935,7 +935,7 @@ Network.NetworkLogView = class extends UI.VBox {
* @param {!SDK.NetworkRequest} request
*/
_refreshRequest(request) {
- if (!this._nodesByRequestId.get(request.requestId))
+ if (!this._nodesByRequestId.get(request.requestId()))
return;
Network.NetworkLogView._subdomains(request.domain)
@@ -979,7 +979,7 @@ Network.NetworkLogView = class extends UI.VBox {
this._suggestionBuilder.addItem(Network.NetworkLogView.FilterType.SetCookieValue, cookie.value());
}
- this._staleRequestIds[request.requestId] = true;
+ this._staleRequestIds[request.requestId()] = true;
this.dispatchEventToListeners(Network.NetworkLogView.Events.UpdateRequest, request);
this.scheduleRefresh();
}
@@ -1011,7 +1011,7 @@ Network.NetworkLogView = class extends UI.VBox {
}
for (var i = 0; i < requestsToPick.length; ++i) {
var request = requestsToPick[i];
- var node = this._nodesByRequestId.get(request.requestId);
+ var node = this._nodesByRequestId.get(request.requestId());
if (node) {
node.markAsNavigationRequest();
break;
@@ -1529,7 +1529,7 @@ Network.NetworkLogView = class extends UI.VBox {
revealAndHighlightRequest(request) {
this.removeAllNodeHighlights();
- var node = this._nodesByRequestId.get(request.requestId);
+ var node = this._nodesByRequestId.get(request.requestId());
if (node) {
node.reveal();
this._highlightNode(node);

Powered by Google App Engine
This is Rietveld 408576698