Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Unified Diff: third_party/WebKit/Source/devtools/front_end/screencast/ScreencastView.js

Issue 2617283003: [Devtools] Removed getters/setters for NetworkRequest requestId (Closed)
Patch Set: Merge branch 'TYPE_OBJECT_JS' into REMOVE_GETTERS_SETTERS_1 Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/screencast/ScreencastView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/screencast/ScreencastView.js b/third_party/WebKit/Source/devtools/front_end/screencast/ScreencastView.js
index f2704428dc93907104a3d3436172bfb54e649663..6a685c4eb409ba91cffa1bea287b1274cda1320f 100644
--- a/third_party/WebKit/Source/devtools/front_end/screencast/ScreencastView.js
+++ b/third_party/WebKit/Source/devtools/front_end/screencast/ScreencastView.js
@@ -838,7 +838,7 @@ Screencast.ScreencastView.ProgressTracker = class {
// Ignore long-living WebSockets for the sake of progress indicator, as we won't be waiting them anyway.
if (request.type === Common.resourceTypes.WebSocket)
return;
- this._requestIds[request.requestId] = request;
+ this._requestIds[request.requestId()] = request;
++this._startedRequests;
}
@@ -846,7 +846,7 @@ Screencast.ScreencastView.ProgressTracker = class {
if (!this._navigationProgressVisible())
return;
var request = /** @type {!SDK.NetworkRequest} */ (event.data);
- if (!(request.requestId in this._requestIds))
+ if (!(request.requestId() in this._requestIds))
return;
++this._finishedRequests;
setTimeout(function() {

Powered by Google App Engine
This is Rietveld 408576698