Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2616003003: Revert of Delete Mac & Cairo skia::BitmapPlatformDevice impls (Closed)

Created:
3 years, 11 months ago by sky
Modified:
3 years, 11 months ago
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Delete Mac & Cairo skia::BitmapPlatformDevice impls (patchset #3 id:40001 of https://codereview.chromium.org/2611153002/ ) Reason for revert: Revert in hopes of fix linux x64 bot: https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%20x64/builds/15545 Original issue's description: > Delete Mac & Cairo skia::BitmapPlatformDevice impls > > We are no longer performing native drawing on these platforms, use the > Skia placeholder instead. > > BUG=675977 > R=reed@google.com > TBR= > > Review-Url: https://codereview.chromium.org/2611153002 > Cr-Commit-Position: refs/heads/master@{#441750} > Committed: https://chromium.googlesource.com/chromium/src/+/ccdceaed36d07ad5ab6d5e504ece0459a4aeaddf TBR=reed@google.com,robertphillips@chromium.org,fmalita@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=675977 Review-Url: https://codereview.chromium.org/2616003003 Cr-Commit-Position: refs/heads/master@{#441776} Committed: https://chromium.googlesource.com/chromium/src/+/0f9a13711bef4107aeeb4e15ee296b917228c141

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+691 lines, -27 lines) Patch
M skia/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
A skia/ext/bitmap_platform_device.h View 1 chunk +23 lines, -0 lines 0 comments Download
A skia/ext/bitmap_platform_device_cairo.h View 1 chunk +104 lines, -0 lines 0 comments Download
A skia/ext/bitmap_platform_device_cairo.cc View 1 chunk +180 lines, -0 lines 0 comments Download
A skia/ext/bitmap_platform_device_mac.h View 1 chunk +73 lines, -0 lines 0 comments Download
A skia/ext/bitmap_platform_device_mac.cc View 1 chunk +275 lines, -0 lines 0 comments Download
M skia/ext/bitmap_platform_device_skia.h View 2 chunks +8 lines, -11 lines 0 comments Download
M skia/ext/bitmap_platform_device_skia.cc View 3 chunks +21 lines, -11 lines 0 comments Download
M skia/ext/bitmap_platform_device_win.h View 1 chunk +2 lines, -2 lines 0 comments Download
M skia/ext/platform_device.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/native_theme/native_theme_win.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
sky
Created Revert of Delete Mac & Cairo skia::BitmapPlatformDevice impls
3 years, 11 months ago (2017-01-06 00:07:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2616003003/1
3 years, 11 months ago (2017-01-06 00:08:19 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 00:09:50 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0f9a13711bef4107aeeb4e15ee29...

Powered by Google App Engine
This is Rietveld 408576698