Delete Mac & Cairo skia::BitmapPlatformDevice impls

Delete Mac & Cairo skia::BitmapPlatformDevice impls

(reland with updated Linux .deb shared lib deps)

We are no longer performing native drawing on these platforms, use the
Skia placeholder instead.

BUG=675977
R=reed@google.com
TBR=

Review-Url: https://codereview.chromium.org/2611153002
Cr-Commit-Position: refs/heads/master@{#442023}
Committed: https://chromium.googlesource.com/chromium/src/+/09884beef8d9c585d4debd606c394bbd68e44ad5

[f(malita), 2017-01-05 16:29:12]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-05 16:29:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[reed1, 2017-01-05 16:40:33]

https://codereview.chromium.org/2611153002/diff/1/skia/ext/bitmap_platform_de...
File skia/ext/bitmap_platform_device_skia.cc (right):

https://codereview.chromium.org/2611153002/diff/1/skia/ext/bitmap_platform_de...
skia/ext/bitmap_platform_device_skia.cc:52: NativeDrawingContext
BitmapPlatformDevice::BeginPlatformPaint(
Can we remove this method from the API entirely? I think its only called
internally by bitmap_..._win.cc

[reed1, 2017-01-05 16:50:39]

Ah, I see the additional complexity with that method. lgtm

[commit-bot: I haz the power, 2017-01-05 16:55:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 16:55:51]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[f(malita), 2017-01-05 17:34:47]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-05 17:35:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[f(malita), 2017-01-05 17:54:46]

Description was changed from

==========
Delete Mac & Cairo skia::BitmapPlatformDevice impls

We are no longer performing native drawing on these platforms, use the
Skia placeholder instead.

BUG=675977
R=reed@google.com
==========

to

==========
Delete Mac & Cairo skia::BitmapPlatformDevice impls

We are no longer performing native drawing on these platforms, use the
Skia placeholder instead.

BUG=675977
R=reed@google.com
==========

[f(malita), 2017-01-05 17:54:46]

fmalita@chromium.org changed reviewers:
+ robertphillips@chromium.org

[commit-bot: I haz the power, 2017-01-05 18:36:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 18:36:31]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[f(malita), 2017-01-05 19:58:47]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-05 19:59:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[f(malita), 2017-01-05 20:09:19]

The CQ bit was unchecked by fmalita@chromium.org

[f(malita), 2017-01-05 20:09:23]

The CQ bit was checked by fmalita@chromium.org

[f(malita), 2017-01-05 20:09:23]

The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com
Link to the patchset: https://codereview.chromium.org/2611153002/#ps40001
(title: "fix null-data initialization behavior")

[f(malita), 2017-01-05 20:09:30]

The CQ bit was unchecked by fmalita@chromium.org

[commit-bot: I haz the power, 2017-01-05 20:09:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[f(malita), 2017-01-05 20:10:13]

Description was changed from

==========
Delete Mac & Cairo skia::BitmapPlatformDevice impls

We are no longer performing native drawing on these platforms, use the
Skia placeholder instead.

BUG=675977
R=reed@google.com
==========

to

==========
Delete Mac & Cairo skia::BitmapPlatformDevice impls

We are no longer performing native drawing on these platforms, use the
Skia placeholder instead.

BUG=675977
R=reed@google.com
TBR=
==========

[f(malita), 2017-01-05 20:10:58]

TBR-ing trivial ui/native_theme/native_theme_win.cc header removal.

[f(malita), 2017-01-05 20:11:02]

The CQ bit was checked by fmalita@chromium.org

[commit-bot: I haz the power, 2017-01-05 20:11:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 21:14:00]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1483647062439630,
"parent_rev": "53ce627c8aa95544706c84a918170a8e53f5a20e", "commit_rev":
"ccdceaed36d07ad5ab6d5e504ece0459a4aeaddf"}

[commit-bot: I haz the power, 2017-01-05 21:14:28]

Description was changed from

==========
Delete Mac & Cairo skia::BitmapPlatformDevice impls

We are no longer performing native drawing on these platforms, use the
Skia placeholder instead.

BUG=675977
R=reed@google.com
TBR=
==========

to

==========
Delete Mac & Cairo skia::BitmapPlatformDevice impls

We are no longer performing native drawing on these platforms, use the
Skia placeholder instead.

BUG=675977
R=reed@google.com
TBR=

Review-Url: https://codereview.chromium.org/2611153002
Cr-Commit-Position: refs/heads/master@{#441750}
Committed:
https://chromium.googlesource.com/chromium/src/+/ccdceaed36d07ad5ab6d5e504ece...
==========

[commit-bot: I haz the power, 2017-01-05 21:14:30]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/ccdceaed36d07ad5ab6d5e504ece...

[sky, 2017-01-06 00:07:29]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2616003003/ by sky@chromium.org.

The reason for reverting is: Revert in hopes of fix linux x64 bot:
https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux...
.

[sky, 2017-01-06 01:03:04]

On 2017/01/06 00:07:29, sky wrote:
> A revert of this CL (patchset #3 id:40001) has been created in
> https://codereview.chromium.org/2616003003/ by mailto:sky@chromium.org.
> 
> The reason for reverting is: Revert in hopes of fix linux x64 bot:
>
https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux...
> .

This was in fact the curlprit. Here's the build output:

python ../../chrome/installer/linux/flock_make_package.py linux_package.lock
installer/debian/build.sh -o . -b . -a x64 -c unstable -d google_chrome -s
/b/c/b/Google_Chrome_Linux_x64/src/build/linux/debian_wheezy_amd64-sysroot -e
/b/c/b/Google_Chrome_Linux_x64/src/third_party/dpkg-dev
dpkg-shlibdeps.pl: warning: binaries to analyze should already be installed in
their package's directory
---
/b/c/b/Google_Chrome_Linux_x64/src/out/Release/installer/debian/expected_deps_x64_wheezy	2017-01-05
13:28:35.688332043 -0800
+++ actual	2017-01-05 14:16:10.462510094 -0800
@@ -2,7 +2,7 @@
 libasound2 (>= 1.0.16)
 libatk1.0-0 (>= 1.12.4)
 libc6 (>= 2.11)
-libcairo2 (>= 1.6.0)
+libcairo2 (>= 1.2.4)
 libcups2 (>= 1.4.0)
 libdbus-1-3 (>= 1.1.4)
 libexpat1 (>= 2.0.1)

ERROR: Shared library dependencies changed!
If this is intentional, please update:
chrome/installer/linux/debian/expected_deps_ia32_jessie
chrome/installer/linux/debian/expected_deps_ia32_wheezy
chrome/installer/linux/debian/expected_deps_x64_jessie
chrome/installer/linux/debian/expected_deps_x64_wheezy

[f(malita), 2017-01-06 14:20:43]

Description was changed from

==========
Delete Mac & Cairo skia::BitmapPlatformDevice impls

We are no longer performing native drawing on these platforms, use the
Skia placeholder instead.

BUG=675977
R=reed@google.com
TBR=

Review-Url: https://codereview.chromium.org/2611153002
Cr-Commit-Position: refs/heads/master@{#441750}
Committed:
https://chromium.googlesource.com/chromium/src/+/ccdceaed36d07ad5ab6d5e504ece...
==========

to

==========
Delete Mac & Cairo skia::BitmapPlatformDevice impls

We are no longer performing native drawing on these platforms, use the
Skia placeholder instead.

BUG=675977
R=reed@google.com
TBR=

Review-Url: https://codereview.chromium.org/2611153002
Cr-Commit-Position: refs/heads/master@{#441750}
Committed:
https://chromium.googlesource.com/chromium/src/+/ccdceaed36d07ad5ab6d5e504ece...
==========

[f(malita), 2017-01-06 14:21:13]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 14:21:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[f(malita), 2017-01-06 14:21:57]

The CQ bit was unchecked by fmalita@chromium.org

[f(malita), 2017-01-06 14:22:55]

Description was changed from

==========
Delete Mac & Cairo skia::BitmapPlatformDevice impls

We are no longer performing native drawing on these platforms, use the
Skia placeholder instead.

BUG=675977
R=reed@google.com
TBR=

Review-Url: https://codereview.chromium.org/2611153002
Cr-Commit-Position: refs/heads/master@{#441750}
Committed:
https://chromium.googlesource.com/chromium/src/+/ccdceaed36d07ad5ab6d5e504ece...
==========

to

==========
Delete Mac & Cairo skia::BitmapPlatformDevice impls

(reland with updated Linux .deb shared lib deps)

We are no longer performing native drawing on these platforms, use the
Skia placeholder instead.

BUG=675977
R=reed@google.com
TBR=

Review-Url: https://codereview.chromium.org/2611153002
Cr-Commit-Position: refs/heads/master@{#441750}
Committed:
https://chromium.googlesource.com/chromium/src/+/ccdceaed36d07ad5ab6d5e504ece...
==========

[f(malita), 2017-01-06 14:30:21]

Description was changed from

==========
Delete Mac & Cairo skia::BitmapPlatformDevice impls

(reland with updated Linux .deb shared lib deps)

We are no longer performing native drawing on these platforms, use the
Skia placeholder instead.

BUG=675977
R=reed@google.com
TBR=

Review-Url: https://codereview.chromium.org/2611153002
Cr-Commit-Position: refs/heads/master@{#441750}
Committed:
https://chromium.googlesource.com/chromium/src/+/ccdceaed36d07ad5ab6d5e504ece...
==========

to

==========
Delete Mac & Cairo skia::BitmapPlatformDevice impls

(reland with updated Linux .deb shared lib deps)

We are no longer performing native drawing on these platforms, use the
Skia placeholder instead.

BUG=675977
R=reed@google.com
TBR=
==========

[f(malita), 2017-01-06 14:30:21]

fmalita@chromium.org changed reviewers:
+ mmoss@chromium.org, phajdan.jr@chromium.org

[f(malita), 2017-01-06 14:31:53]

On 2017/01/06 01:03:04, sky wrote:
> On 2017/01/06 00:07:29, sky wrote:
> > A revert of this CL (patchset #3 id:40001) has been created in
> > https://codereview.chromium.org/2616003003/ by mailto:sky@chromium.org.
> > 
> > The reason for reverting is: Revert in hopes of fix linux x64 bot:
> >
>
https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux...
> > .
> 
> This was in fact the curlprit. Here's the build output:
> 
> python ../../chrome/installer/linux/flock_make_package.py linux_package.lock
> installer/debian/build.sh -o . -b . -a x64 -c unstable -d google_chrome -s
> /b/c/b/Google_Chrome_Linux_x64/src/build/linux/debian_wheezy_amd64-sysroot -e
> /b/c/b/Google_Chrome_Linux_x64/src/third_party/dpkg-dev
> dpkg-shlibdeps.pl: warning: binaries to analyze should already be installed in
> their package's directory
> ---
>
/b/c/b/Google_Chrome_Linux_x64/src/out/Release/installer/debian/expected_deps_x64_wheezy	2017-01-05
> 13:28:35.688332043 -0800
> +++ actual	2017-01-05 14:16:10.462510094 -0800
> @@ -2,7 +2,7 @@
>  libasound2 (>= 1.0.16)
>  libatk1.0-0 (>= 1.12.4)
>  libc6 (>= 2.11)
> -libcairo2 (>= 1.6.0)
> +libcairo2 (>= 1.2.4)
>  libcups2 (>= 1.4.0)
>  libdbus-1-3 (>= 1.1.4)
>  libexpat1 (>= 2.0.1)
> 
> ERROR: Shared library dependencies changed!
> If this is intentional, please update:
> chrome/installer/linux/debian/expected_deps_ia32_jessie
> chrome/installer/linux/debian/expected_deps_ia32_wheezy
> chrome/installer/linux/debian/expected_deps_x64_jessie
> chrome/installer/linux/debian/expected_deps_x64_wheezy

Thanks.

+mmoss/phajdan.jr for chrome/installer/linux/debian/ libcairo2 deps change.

[Michael Moss, 2017-01-06 20:06:56]

lgtm

[f(malita), 2017-01-06 20:07:52]

The CQ bit was checked by fmalita@chromium.org

[f(malita), 2017-01-06 20:07:53]

The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com
Link to the patchset: https://codereview.chromium.org/2611153002/#ps60001
(title: "shared lib deps change")

[commit-bot: I haz the power, 2017-01-06 20:08:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 20:13:42]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1483733272783450,
"parent_rev": "9d43cc2631f51968d3790e8709dde20bdedb5a6d", "commit_rev":
"09884beef8d9c585d4debd606c394bbd68e44ad5"}

[commit-bot: I haz the power, 2017-01-06 20:14:15]

Description was changed from

==========
Delete Mac & Cairo skia::BitmapPlatformDevice impls

(reland with updated Linux .deb shared lib deps)

We are no longer performing native drawing on these platforms, use the
Skia placeholder instead.

BUG=675977
R=reed@google.com
TBR=
==========

to

==========
Delete Mac & Cairo skia::BitmapPlatformDevice impls

(reland with updated Linux .deb shared lib deps)

We are no longer performing native drawing on these platforms, use the
Skia placeholder instead.

BUG=675977
R=reed@google.com
TBR=

Review-Url: https://codereview.chromium.org/2611153002
Cr-Commit-Position: refs/heads/master@{#442023}
Committed:
https://chromium.googlesource.com/chromium/src/+/09884beef8d9c585d4debd606c39...
==========

[commit-bot: I haz the power, 2017-01-06 20:14:16]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/09884beef8d9c585d4debd606c39...