Typemap device.usb.DeviceFilter to device::UsbDeviceFilter.

Typemap device.usb.DeviceFilter to device::UsbDeviceFilter.

This patch makes device::UsbDeviceFilter a struct using base::Optional
for the previously manually optional fields and typemaps the Mojo device
filter type to it in Chrome code.

BUG=None

Review-Url: https://codereview.chromium.org/2615353002
Cr-Commit-Position: refs/heads/master@{#444145}
Committed: https://chromium.googlesource.com/chromium/src/+/b71b7d5967c31b07766cf0ad10be89a9e526ed4a

[Reilly Grant (use Gerrit), 2017-01-06 23:28:53]

The CQ bit was checked by reillyg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 23:29:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 23:46:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 23:46:01]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Reilly Grant (use Gerrit), 2017-01-07 02:01:55]

Rebased.

[Reilly Grant (use Gerrit), 2017-01-07 02:02:46]

The CQ bit was checked by reillyg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-07 02:02:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-07 02:19:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-07 02:19:19]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Reilly Grant (use Gerrit), 2017-01-07 02:31:27]

Fix test after rebase.

[Reilly Grant (use Gerrit), 2017-01-07 02:31:29]

The CQ bit was checked by reillyg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-07 02:31:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-07 02:48:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-07 02:48:49]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[Reilly Grant (use Gerrit), 2017-01-09 22:37:02]

Fix GCC build.

[Reilly Grant (use Gerrit), 2017-01-09 22:38:07]

The CQ bit was checked by reillyg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-09 22:38:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-09 23:05:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-09 23:05:29]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Reilly Grant (use Gerrit), 2017-01-09 23:43:12]

Fix the rest of the Android build.

[Reilly Grant (use Gerrit), 2017-01-09 23:45:19]

The CQ bit was checked by reillyg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-09 23:46:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 01:19:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 01:19:57]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[Reilly Grant (use Gerrit), 2017-01-10 01:59:44]

Fix Android Clang build.

[Reilly Grant (use Gerrit), 2017-01-10 01:59:46]

The CQ bit was checked by reillyg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 02:01:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 05:06:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 05:06:03]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Reilly Grant (use Gerrit), 2017-01-10 22:17:35]

Rebased.

[Reilly Grant (use Gerrit), 2017-01-11 20:08:35]

The CQ bit was checked by reillyg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 20:09:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 20:33:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 20:33:52]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Reilly Grant (use Gerrit), 2017-01-11 22:38:59]

Description was changed from

==========
Typemap device.usb.DeviceFilter to device::UsbDeviceFilter.

This patch makes device::UsbDeviceFilter a struct using base::Optional
for the previously manually optional fields and typemaps the Mojo device
filter type to it in Chrome code.

BUG=None
==========

to

==========
Typemap device.usb.DeviceFilter to device::UsbDeviceFilter.

This patch makes device::UsbDeviceFilter a struct using base::Optional
for the previously manually optional fields and typemaps the Mojo device
filter type to it in Chrome code.

BUG=None
==========

[Reilly Grant (use Gerrit), 2017-01-11 22:38:59]

reillyg@chromium.org changed reviewers:
+ dcheng@chromium.org, juncai@chromium.org, stevenjb@chromium.org,
tedchoc@chromium.org

[Reilly Grant (use Gerrit), 2017-01-11 23:01:22]

juncai@, please do a general review.
tedchoc@, please review */android/*
stevenjb@, please review chrome/browser/chromeos
dcheng@, please review *_struct_traits.h

[stevenjb, 2017-01-11 23:05:50]

c/b/chromeos RS lgtm

[juncai, 2017-01-12 00:50:23]

LGTM with nits.

https://codereview.chromium.org/2615353002/diff/120001/device/usb/public/inte...
File device/usb/public/interfaces/device_manager_struct_traits.h (right):

https://codereview.chromium.org/2615353002/diff/120001/device/usb/public/inte...
device/usb/public/interfaces/device_manager_struct_traits.h:57:
device::UsbDeviceFilter* output) {
nit: move this function to .cpp file?

https://codereview.chromium.org/2615353002/diff/120001/device/usb/usb_device_...
File device/usb/usb_device_filter.cc (right):

https://codereview.chromium.org/2615353002/diff/120001/device/usb/usb_device_...
device/usb/usb_device_filter.cc:66: if (product_id) {
nit: remove '{}' for single line.

https://codereview.chromium.org/2615353002/diff/120001/device/usb/usb_device_...
device/usb/usb_device_filter.cc:89: for (const UsbDeviceFilter& filter :
filters) {
nit: const auto&?

https://codereview.chromium.org/2615353002/diff/120001/extensions/common/api/...
File extensions/common/api/printer_provider/usb_printer_manifest_data.cc
(right):

https://codereview.chromium.org/2615353002/diff/120001/extensions/common/api/...
extensions/common/api/printer_provider/usb_printer_manifest_data.cc:50: if
(input.product_id)
nit: maybe use:
"else if (input.product_id)
   ...
 else if (input.interface_class) {
   ...
 }"
This can make it more clear that at most one of productId or interfaceClass may
be specified.

[Reilly Grant (use Gerrit), 2017-01-12 02:18:33]

Addressed juncai@'s feedback.

[Reilly Grant (use Gerrit), 2017-01-12 02:18:35]

The CQ bit was checked by reillyg@chromium.org to run a CQ dry run

[Reilly Grant (use Gerrit), 2017-01-12 02:18:44]

https://codereview.chromium.org/2615353002/diff/120001/device/usb/public/inte...
File device/usb/public/interfaces/device_manager_struct_traits.h (right):

https://codereview.chromium.org/2615353002/diff/120001/device/usb/public/inte...
device/usb/public/interfaces/device_manager_struct_traits.h:57:
device::UsbDeviceFilter* output) {
On 2017/01/12 00:50:23, juncai wrote:
> nit: move this function to .cpp file?

Done.

https://codereview.chromium.org/2615353002/diff/120001/device/usb/usb_device_...
File device/usb/usb_device_filter.cc (right):

https://codereview.chromium.org/2615353002/diff/120001/device/usb/usb_device_...
device/usb/usb_device_filter.cc:66: if (product_id) {
On 2017/01/12 00:50:23, juncai wrote:
> nit: remove '{}' for single line.

Done.

https://codereview.chromium.org/2615353002/diff/120001/device/usb/usb_device_...
device/usb/usb_device_filter.cc:89: for (const UsbDeviceFilter& filter :
filters) {
On 2017/01/12 00:50:23, juncai wrote:
> nit: const auto&?

Done.

https://codereview.chromium.org/2615353002/diff/120001/extensions/common/api/...
File extensions/common/api/printer_provider/usb_printer_manifest_data.cc
(right):

https://codereview.chromium.org/2615353002/diff/120001/extensions/common/api/...
extensions/common/api/printer_provider/usb_printer_manifest_data.cc:50: if
(input.product_id)
On 2017/01/12 00:50:23, juncai wrote:
> nit: maybe use:
> "else if (input.product_id)
>    ...
>  else if (input.interface_class) {
>    ...
>  }"
> This can make it more clear that at most one of productId or interfaceClass
may
> be specified.

I think the coding style says not to put else if after if clauses that return.

[commit-bot: I haz the power, 2017-01-12 02:18:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 02:33:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 02:33:13]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[dcheng, 2017-01-12 09:39:03]

mojo lgtm

[Ted C, 2017-01-13 16:17:24]

On 2017/01/12 09:39:03, dcheng wrote:
> mojo lgtm

android lgtm

[Reilly Grant (use Gerrit), 2017-01-17 19:41:30]

The CQ bit was checked by reillyg@chromium.org

[Reilly Grant (use Gerrit), 2017-01-17 19:41:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org, juncai@chromium.org
Link to the patchset: https://codereview.chromium.org/2615353002/#ps140001
(title: "Addressed juncai@'s feedback.")

[commit-bot: I haz the power, 2017-01-17 19:41:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-17 21:17:10]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1484682090354700,
"parent_rev": "5f361b8c1b1d655d3adc3b816599e72159a235b3", "commit_rev":
"b71b7d5967c31b07766cf0ad10be89a9e526ed4a"}

[commit-bot: I haz the power, 2017-01-17 21:17:43]

Description was changed from

==========
Typemap device.usb.DeviceFilter to device::UsbDeviceFilter.

This patch makes device::UsbDeviceFilter a struct using base::Optional
for the previously manually optional fields and typemaps the Mojo device
filter type to it in Chrome code.

BUG=None
==========

to

==========
Typemap device.usb.DeviceFilter to device::UsbDeviceFilter.

This patch makes device::UsbDeviceFilter a struct using base::Optional
for the previously manually optional fields and typemaps the Mojo device
filter type to it in Chrome code.

BUG=None

Review-Url: https://codereview.chromium.org/2615353002
Cr-Commit-Position: refs/heads/master@{#444145}
Committed:
https://chromium.googlesource.com/chromium/src/+/b71b7d5967c31b07766cf0ad10be...
==========

[commit-bot: I haz the power, 2017-01-17 21:17:44]

Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/b71b7d5967c31b07766cf0ad10be...

[Wez, 2017-02-07 22:26:35]

wez@chromium.org changed reviewers:
+ rockot@chromium.org

[Wez, 2017-02-07 22:26:36]

Hallo rockot@chromium.org!
Due to a depot_tools patch which mistakenly removed the OWNERS check for
non-source files (see crbug.com/684270), the following files landed in this CL
and need a retrospective rubber-stampesque review from you:
	mojo/public/tools/bindings/chromium_bindings_configuration.gni
Thanks,
Wez

[Ken Rockot(use gerrit already), 2017-02-07 22:28:00]

lgtm