Typemap device.usb.DeviceFilter to device::UsbDeviceFilter.

extensions/common/api/printer_provider/usb_printer_manifest_data.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/common/api/printer_provider/usb_printer_manifest_data.h"
 
+#include "base/memory/ptr_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "device/usb/usb_device.h"
 #include "device/usb/usb_device_filter.h"
 #include "extensions/common/api/extensions_manifest_types.h"
 #include "extensions/common/manifest_constants.h"
 
 using device::UsbDeviceFilter;
 
 namespace extensions {
 
@@ skipping 13 matching lines @@
 // static
 std::unique_ptr<UsbPrinterManifestData> UsbPrinterManifestData::FromValue(
     const base::Value& value,
     base::string16* error) {
   std::unique_ptr<api::extensions_manifest_types::UsbPrinters> usb_printers =
       api::extensions_manifest_types::UsbPrinters::FromValue(value, error);
   if (!usb_printers) {
     return nullptr;
   }
 
-  std::unique_ptr<UsbPrinterManifestData> result(new UsbPrinterManifestData());
+  auto result = base::MakeUnique<UsbPrinterManifestData>();
   for (const auto& input : usb_printers->filters) {
     UsbDeviceFilter output;
-    output.SetVendorId(input.vendor_id);
+    output.vendor_id = input.vendor_id;
     if (input.product_id && input.interface_class) {
       *error = base::ASCIIToUTF16(
           "Only one of productId or interfaceClass may be specified.");
       return nullptr;
     }
-    if (input.product_id) {
-      output.SetProductId(*input.product_id);
-    }
+    if (input.product_id)

[juncai, 2017/01/12 00:50:23]

nit: maybe use:
"else if (input.product_id)
   ...
 else if (input.interface_class) {
   ...
 }"
This can make it more clear that at most one of productId or interfaceClass may
be specified.

[Reilly Grant (use Gerrit), 2017/01/12 02:18:44]

I think the coding style says not to put else if after if clauses that return.

+      output.product_id = *input.product_id;
     if (input.interface_class) {
-      output.SetInterfaceClass(*input.interface_class);
+      output.interface_class = *input.interface_class;
       if (input.interface_subclass) {
-        output.SetInterfaceSubclass(*input.interface_subclass);
-        if (input.interface_protocol) {
-          output.SetInterfaceProtocol(*input.interface_protocol);
-        }
+        output.interface_subclass = *input.interface_subclass;
+        if (input.interface_protocol)
+          output.interface_protocol = *input.interface_protocol;
       }
     }
     result->filters_.push_back(output);
   }
   return result;
 }
 
 bool UsbPrinterManifestData::SupportsDevice(
     const scoped_refptr<device::UsbDevice>& device) const {
   for (const auto& filter : filters_) {
     if (filter.Matches(device))
       return true;
   }
 
   return false;
 }
 
 }  // namespace extensions