chrome/browser/usb/web_usb_chooser_service.h - Issue 2615353002: Typemap device.usb.DeviceFilter to device::UsbDeviceFilter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/usb/web_usb_chooser_service.h

Issue 2615353002: Typemap device.usb.DeviceFilter to device::UsbDeviceFilter. (Closed)

Patch Set: Addressed juncai@'s feedback. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/usb/web_usb_chooser_service.h

diff --git a/chrome/browser/usb/web_usb_chooser_service.h b/chrome/browser/usb/web_usb_chooser_service.h

index 0b98830837ca0b2193b7a9f7975e6b8f433672e8..3b4c0b13711bf354af0f6551533efffd03de53e7 100644

--- a/chrome/browser/usb/web_usb_chooser_service.h

+++ b/chrome/browser/usb/web_usb_chooser_service.h

@@ -27,7 +27,7 @@ class WebUsbChooserService : public device::usb::ChooserService {

~WebUsbChooserService() override;

// device::usb::ChooserService:

- void GetPermission(std::vector<device::usb::DeviceFilterPtr> device_filters,

+ void GetPermission(const std::vector<device::UsbDeviceFilter>& device_filters,

const GetPermissionCallback& callback) override;

void Bind(mojo::InterfaceRequest<device::usb::ChooserService> request);