device/usb/mojo/device_manager_impl.cc - Issue 2615353002: Typemap device.usb.DeviceFilter to device::UsbDeviceFilter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/usb/mojo/device_manager_impl.cc

Issue 2615353002: Typemap device.usb.DeviceFilter to device::UsbDeviceFilter. (Closed)

Patch Set: Addressed juncai@'s feedback. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: device/usb/mojo/device_manager_impl.cc

diff --git a/device/usb/mojo/device_manager_impl.cc b/device/usb/mojo/device_manager_impl.cc

index 1be91ec9663b643cffffa88f333a6142f17ec020..d7657deb6db7293da8bc13e4fb61f261b797fe0f 100644

--- a/device/usb/mojo/device_manager_impl.cc

+++ b/device/usb/mojo/device_manager_impl.cc

@@ -88,7 +88,7 @@ void DeviceManagerImpl::OnGetDevices(

const std::vector<scoped_refptr<UsbDevice>>& devices) {

std::vector<UsbDeviceFilter> filters;

if (options && options->filters)

- filters = mojo::ConvertTo<std::vector<UsbDeviceFilter>>(*options->filters);

+ filters.swap(*options->filters);

std::vector<DeviceInfoPtr> device_infos;

for (const auto& device : devices) {