Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 2613803002: Add compressedTex{Sub}Image{2|3}D using PBO signatures to WebGL2 (Closed)

Created:
3 years, 11 months ago by Zhenyao Mo
Modified:
3 years, 11 months ago
CC:
chromium-reviews, blink-reviews, haraken, Kai Ninomiya
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add compressedTex{Sub}Image{2|3}D using PBO signatures to WebGL2 BUG=662644 TEST=conformance R=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2613803002 Cr-Commit-Position: refs/heads/master@{#441695} Committed: https://chromium.googlesource.com/chromium/src/+/4d44e971a41797ff8bf686d92d0e58480be5c6b3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -0 lines) Patch
M third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h View 1 chunk +37 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp View 4 chunks +65 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.idl View 1 chunk +13 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (8 generated)
Zhenyao Mo
kbr: PTAL kainino: FYI
3 years, 11 months ago (2017-01-05 00:23:15 UTC) #2
Ken Russell (switch to Gerrit)
LGTM, but please wait for the spec to be updated in https://github.com/KhronosGroup/WebGL/pull/2234 before landing this.
3 years, 11 months ago (2017-01-05 00:50:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2613803002/1
3 years, 11 months ago (2017-01-05 17:38:42 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-05 17:43:33 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4d44e971a41797ff8bf686d92d0e...

Powered by Google App Engine
This is Rietveld 408576698