Fix namespace for src/ui/display/.

Fix namespace for src/ui/display/.

New classes under src/ui/display have been added to namespace display
and some of the existing classes have been moved into namespace display.
The remaining classes are still under namespace ui. Keeping track of
what class is ui vs display is confusing. This CL performs a bulk update
of all remaining classes and moves them into namespace display.

This CL is a purely mechanical change that updates namespace ui to
namespace display. There should be no logic changes. I updated a few
comments by hand for formatting and other inconsistencies.

BUG=677973
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=elijahtaylor@chromium.org,jochen@chromium.org,danakj@chromium.org

Review-Url: https://codereview.chromium.org/2613493002
Cr-Commit-Position: refs/heads/master@{#442126}
Committed: https://chromium.googlesource.com/chromium/src/+/7a067ec8b62a60060a12eff32a5267b5fcded66c

[kylechar, 2017-01-03 16:15:07]

Description was changed from

==========
Fix namespace for src/ui/display/*

Finish moving everything under src/ui/display/ into namespace display.
The current inconsistent state is confusing.

BUG=677973
==========

to

==========
Fix namespace for src/ui/display/*

Finish moving everything under src/ui/display/ into namespace display.
The current inconsistent state is confusing.

BUG=677973
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[kylechar, 2017-01-03 16:33:31]

Description was changed from

==========
Fix namespace for src/ui/display/*

Finish moving everything under src/ui/display/ into namespace display.
The current inconsistent state is confusing.

BUG=677973
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Fix namespace for src/ui/display/*

Finish moving everything under src/ui/display/ into namespace display.
The current inconsistent state is confusing.

This CL is a purely mechanical change that updates namespace ui to
namespace display.

BUG=677973
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[kylechar, 2017-01-03 16:34:46]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-03 16:34:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-03 16:52:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-03 16:52:35]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[kylechar, 2017-01-03 18:50:28]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-03 18:50:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-03 20:37:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-03 20:37:52]

Dry run: This issue passed the CQ dry run.

[kylechar, 2017-01-04 14:58:46]

Description was changed from

==========
Fix namespace for src/ui/display/*

Finish moving everything under src/ui/display/ into namespace display.
The current inconsistent state is confusing.

This CL is a purely mechanical change that updates namespace ui to
namespace display.

BUG=677973
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Fix namespace for src/ui/display/.

New classes under src/ui/display have been added to namespace display
and some of the existing classes have been moved into namespace display.
The remaining classes are still under namespace ui. Keeping track of
what class is ui vs display is confusing. This CL performs a bulk update
of all remaining classes and moves them into namespace display.

This CL is a purely mechanical change that updates namespace ui to
namespace display. There should be no logic changes. I updated a few
comments by hand for formatting and other inconsistencies.

BUG=677973
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[kylechar, 2017-01-04 14:59:13]

Description was changed from

==========
Fix namespace for src/ui/display/.

New classes under src/ui/display have been added to namespace display
and some of the existing classes have been moved into namespace display.
The remaining classes are still under namespace ui. Keeping track of
what class is ui vs display is confusing. This CL performs a bulk update
of all remaining classes and moves them into namespace display.

This CL is a purely mechanical change that updates namespace ui to
namespace display. There should be no logic changes. I updated a few
comments by hand for formatting and other inconsistencies.

BUG=677973
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Fix namespace for src/ui/display/.

New classes under src/ui/display have been added to namespace display
and some of the existing classes have been moved into namespace display.
The remaining classes are still under namespace ui. Keeping track of
what class is ui vs display is confusing. This CL performs a bulk update
of all remaining classes and moves them into namespace display.

This CL is a purely mechanical change that updates namespace ui to
namespace display. There should be no logic changes. I updated a few
comments by hand for formatting and other inconsistencies.

BUG=677973
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[kylechar, 2017-01-04 15:00:11]

kylechar@chromium.org changed reviewers:
+ oshima@chromium.org, rjkroege@chromium.org

[kylechar, 2017-01-04 15:00:12]

oshima: ash/*, ui/display/*
rjkroege: ui/ozone/*

[rjkroege, 2017-01-04 21:19:51]

lgtm

https://codereview.chromium.org/2613493002/diff/40001/ash/touch/touch_observe...
File ash/touch/touch_observer_hud.h (right):

https://codereview.chromium.org/2613493002/diff/40001/ash/touch/touch_observe...
ash/touch/touch_observer_hud.h:33: #if defined(OS_CHROMEOS)
Now that james has removed ash support for CrOS, seems like the #ifdef could be
removed?

[oshima, 2017-01-05 22:21:25]

lgtm

https://codereview.chromium.org/2613493002/diff/40001/ash/touch/touch_observe...
File ash/touch/touch_observer_hud.h (right):

https://codereview.chromium.org/2613493002/diff/40001/ash/touch/touch_observe...
ash/touch/touch_observer_hud.h:33: #if defined(OS_CHROMEOS)
On 2017/01/04 21:19:50, rjkroege wrote:
> Now that james has removed ash support for CrOS, seems like the #ifdef could
be
> removed?

Not sure if I understand. Can you elaborate?

[kylechar, 2017-01-05 22:29:18]

Thanks, will find OWNERS for the rest of the files now.

https://codereview.chromium.org/2613493002/diff/40001/ash/touch/touch_observe...
File ash/touch/touch_observer_hud.h (right):

https://codereview.chromium.org/2613493002/diff/40001/ash/touch/touch_observe...
ash/touch/touch_observer_hud.h:33: #if defined(OS_CHROMEOS)
On 2017/01/05 22:21:25, oshima wrote:
> On 2017/01/04 21:19:50, rjkroege wrote:
> > Now that james has removed ash support for CrOS, seems like the #ifdef could
> be
> > removed?
> 
> Not sure if I understand. Can you elaborate?

I think rjkroege means that the "ash" target will only build if is_chromeos=true
now (there is an assert in ash/BUILD.gn to make sure of it). So this #ifdef has
to always be true. There is a lot of similar #ifdefs scattered throughout ash.

[kylechar, 2017-01-05 22:36:26]

kylechar@chromium.org changed reviewers:
+ danakj@chromium.org, dbeam@chromium.org, elijahtaylor@chromium.org,
jamescook@chromium.org, jochen@chromium.org, sandersd@chromium.org,
tsepez@chromium.org

[kylechar, 2017-01-05 22:36:27]

+jochen for chrome/browser/*
+dbeam for chrome/browser/ui/webui/options/chromeos/display_options_handler.cc
+elijahtaylor for components/arc/
+danakj for components/display_compositor/buffer_queue_unittest.cc and
content/browser/compositor/gpu_process_transport_factory.cc
+jamescook for extensions/shell/*
+sandersd for media/gpu/*
+tsepez for ui/ozone/common/gpu/*

[Tom Sepez, 2017-01-05 22:42:15]

messages LGTM

[James Cook, 2017-01-05 22:56:39]

extensions/shell lgtm

[sandersd (OOO until July 31), 2017-01-05 23:14:53]

//media/gpu LGTM.

[oshima, 2017-01-06 00:07:09]

https://codereview.chromium.org/2613493002/diff/40001/ash/touch/touch_observe...
File ash/touch/touch_observer_hud.h (right):

https://codereview.chromium.org/2613493002/diff/40001/ash/touch/touch_observe...
ash/touch/touch_observer_hud.h:33: #if defined(OS_CHROMEOS)
On 2017/01/05 22:29:17, kylechar wrote:
> On 2017/01/05 22:21:25, oshima wrote:
> > On 2017/01/04 21:19:50, rjkroege wrote:
> > > Now that james has removed ash support for CrOS, seems like the #ifdef
could
> > be
> > > removed?
> > 
> > Not sure if I understand. Can you elaborate?
> 
> I think rjkroege means that the "ash" target will only build if
is_chromeos=true
> now (there is an assert in ash/BUILD.gn to make sure of it). So this #ifdef
has
> to always be true. There is a lot of similar #ifdefs scattered throughout ash.

Oh, so he meant Win/Linux not CrOS?

[Dan Beam, 2017-01-06 00:52:18]

lgtm

[kylechar, 2017-01-06 17:24:55]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 17:25:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 18:39:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 18:39:04]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[kylechar, 2017-01-06 18:39:28]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 18:40:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 18:51:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 18:51:29]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[kylechar, 2017-01-06 19:33:50]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 19:34:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kylechar, 2017-01-06 21:37:47]

Going to TBR elijahtaylor, jochen and danakj.

[kylechar, 2017-01-06 21:38:25]

Description was changed from

==========
Fix namespace for src/ui/display/.

New classes under src/ui/display have been added to namespace display
and some of the existing classes have been moved into namespace display.
The remaining classes are still under namespace ui. Keeping track of
what class is ui vs display is confusing. This CL performs a bulk update
of all remaining classes and moves them into namespace display.

This CL is a purely mechanical change that updates namespace ui to
namespace display. There should be no logic changes. I updated a few
comments by hand for formatting and other inconsistencies.

BUG=677973
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Fix namespace for src/ui/display/.

New classes under src/ui/display have been added to namespace display
and some of the existing classes have been moved into namespace display.
The remaining classes are still under namespace ui. Keeping track of
what class is ui vs display is confusing. This CL performs a bulk update
of all remaining classes and moves them into namespace display.

This CL is a purely mechanical change that updates namespace ui to
namespace display. There should be no logic changes. I updated a few
comments by hand for formatting and other inconsistencies.

BUG=677973
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=elijahtaylor@chromium.org,jochen@chromium.org,danakj@chromium.org
==========

[danakj, 2017-01-06 21:39:41]

On 2017/01/05 22:36:27, kylechar wrote:
> +jochen for chrome/browser/*
> +dbeam for chrome/browser/ui/webui/options/chromeos/display_options_handler.cc
> +elijahtaylor for components/arc/
> +danakj for components/display_compositor/buffer_queue_unittest.cc and
> content/browser/compositor/gpu_process_transport_factory.cc

sorry did not see my name but LGTM

> +jamescook for extensions/shell/*
> +sandersd for media/gpu/*
> +tsepez for ui/ozone/common/gpu/*

[commit-bot: I haz the power, 2017-01-06 23:54:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 23:54:30]

Dry run: This issue passed the CQ dry run.

[kylechar, 2017-01-07 01:05:20]

The CQ bit was checked by kylechar@chromium.org

[kylechar, 2017-01-07 01:05:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
rjkroege@chromium.org, jamescook@chromium.org, dbeam@chromium.org,
sandersd@chromium.org, oshima@chromium.org, tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/2613493002/#ps80001
(title: "Rebase.")

[commit-bot: I haz the power, 2017-01-07 01:05:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-07 01:16:32]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1483751120043600,
"parent_rev": "68f0df28fa1aac95c808428f3b79846f99c73547", "commit_rev":
"7a067ec8b62a60060a12eff32a5267b5fcded66c"}

[commit-bot: I haz the power, 2017-01-07 01:17:01]

Description was changed from

==========
Fix namespace for src/ui/display/.

New classes under src/ui/display have been added to namespace display
and some of the existing classes have been moved into namespace display.
The remaining classes are still under namespace ui. Keeping track of
what class is ui vs display is confusing. This CL performs a bulk update
of all remaining classes and moves them into namespace display.

This CL is a purely mechanical change that updates namespace ui to
namespace display. There should be no logic changes. I updated a few
comments by hand for formatting and other inconsistencies.

BUG=677973
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=elijahtaylor@chromium.org,jochen@chromium.org,danakj@chromium.org
==========

to

==========
Fix namespace for src/ui/display/.

New classes under src/ui/display have been added to namespace display
and some of the existing classes have been moved into namespace display.
The remaining classes are still under namespace ui. Keeping track of
what class is ui vs display is confusing. This CL performs a bulk update
of all remaining classes and moves them into namespace display.

This CL is a purely mechanical change that updates namespace ui to
namespace display. There should be no logic changes. I updated a few
comments by hand for formatting and other inconsistencies.

BUG=677973
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=elijahtaylor@chromium.org,jochen@chromium.org,danakj@chromium.org

Review-Url: https://codereview.chromium.org/2613493002
Cr-Commit-Position: refs/heads/master@{#442126}
Committed:
https://chromium.googlesource.com/chromium/src/+/7a067ec8b62a60060a12eff32a52...
==========

[commit-bot: I haz the power, 2017-01-07 01:17:03]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/7a067ec8b62a60060a12eff32a52...